Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Buttons in table and cell properties panels are missing aria-pressed attribute #17722

Closed
FilipTokarski opened this issue Jan 8, 2025 · 0 comments · Fixed by #17728
Closed

Buttons in table and cell properties panels are missing aria-pressed attribute #17722

FilipTokarski opened this issue Jan 8, 2025 · 0 comments · Fixed by #17728
Assignees
@Mati365
Labels
domain:accessibility This issue reports an accessibility problem. package:table squad:core Issue to be handled by the Core team. support:2 An issue reported by a commercially licensed client. type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 82

Comments

@FilipTokarski
Copy link
Member

📝 Provide detailed reproduction steps (if any)

When pressing buttons in table and cell properties panel, for example:

Image
Image

buttons should use aria-pressed attribute.

If you'd like to see this fixed sooner, add a 👍 reaction to this post.
@FilipTokarski FilipTokarski added domain:accessibility This issue reports an accessibility problem. package:table squad:core Issue to be handled by the Core team. support:2 An issue reported by a commercially licensed client. type:bug This issue reports a buggy (incorrect) behavior. labels Jan 8, 2025
@Mati365 Mati365 self-assigned this Jan 9, 2025
@Mati365 Mati365 mentioned this issue Jan 9, 2025
Merged
@CKEditorBot CKEditorBot added the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Jan 9, 2025
Mati365 added a commit that referenced this issue Jan 10, 2025
@Mati365
Add aria-checked attribute to align toolbars in table properties. (#…
9333cc9 
…17728)

Feature (table): Improve aria attributes in table and cell align toolbars. Closes #17722
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Jan 10, 2025
@CKEditorBot CKEditorBot added this to the iteration 82 milestone Jan 10, 2025
@CKEditorBot CKEditorBot mentioned this issue Jan 11, 2025
Open
filipsobol pushed a commit that referenced this issue Jan 23, 2025
@Mati365 @filipsobol
Add aria-checked attribute to align toolbars in table properties. (#…
3b4c468 
…17728)

Feature (table): Improve aria attributes in table and cell align toolbars. Closes #17722
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mati365 Mati365

Labels
domain:accessibility This issue reports an accessibility problem. package:table squad:core Issue to be handled by the Core team. support:2 An issue reported by a commercially licensed client. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 82
Development

Successfully merging a pull request may close this issue.

Add aria-checked attribute to align toolbars in table properties. ckeditor/ckeditor5
3 participants
@Mati365 @CKEditorBot @FilipTokarski