Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the performance of lists #17625

Closed
filipsobol opened this issue Dec 11, 2024 · 0 comments · Fixed by #17564
Closed

Improve the performance of lists #17625

filipsobol opened this issue Dec 11, 2024 · 0 comments · Fixed by #17564
Labels
type:improvement This issue reports a possible enhancement of an existing feature.
Milestone
iteration 82

Comments

@filipsobol
Copy link
Member

When investigating performance issues, we noticed that a lot of time in the lists performance test is spent in findAndAddListHeadToMap used in post-fixers. A lot of that work can be avoided, by skipping the list elements that already were visited.
@filipsobol filipsobol added the type:improvement This issue reports a possible enhancement of an existing feature. label Dec 11, 2024
@filipsobol filipsobol mentioned this issue Dec 11, 2024
Merged
filipsobol added a commit that referenced this issue Dec 11, 2024
@filipsobol
Merge pull request #17564 from ckeditor/cache-visited-elements
9fe9a58 
Other (list): Skip already visited list elements during reconversion and post fixing for better performance. Fixes #17625.
@CKEditorBot CKEditorBot added this to the iteration 82 milestone Dec 11, 2024
@CKEditorBot CKEditorBot mentioned this issue Dec 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
iteration 82
Development

Successfully merging a pull request may close this issue.

Skip already visited list elements during reconversion and post fixing ckeditor/ckeditor5
2 participants
@filipsobol @CKEditorBot