Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add custom property for the content copied from the editor in the clipboard pipeline #15935

Closed
Mgsy opened this issue Feb 27, 2024 · 2 comments · Fixed by #17707
Closed

Add custom property for the content copied from the editor in the clipboard pipeline #15935

Mgsy opened this issue Feb 27, 2024 · 2 comments · Fixed by #17707
Assignees
@Mati365
Labels
domain:v4-compatibility This issue reports a CKEditor 4 feature/option that's missing in CKEditor 5. package:clipboard support:2 An issue reported by a commercially licensed client. type:improvement This issue reports a possible enhancement of an existing feature.
Milestone
iteration 83

Comments

@Mgsy
Copy link
Member

Mgsy commented Feb 27, 2024

📝 Provide a description of the improvement

In CKEditor 4, dataTransfer object has a custom property (https://ckeditor.com/docs/ckeditor4/latest/api/CKEDITOR_plugins_clipboard_dataTransfer.html#property-sourceEditor) that indicates whether the data has been copied from the editor.

It would be nice to introduce a way for detecting whether copied content is coming from CKEditor 5.

If you'd like to see this improvement implemented, add a 👍 reaction to this post.
@Mgsy Mgsy added type:improvement This issue reports a possible enhancement of an existing feature. package:clipboard support:2 An issue reported by a commercially licensed client. labels Feb 27, 2024
@Witoso
Copy link
Member

Witoso commented Feb 27, 2024

This is interesting, what is the use case, how such property is used?

@Mgsy
Copy link
Member Author

Mgsy commented Feb 28, 2024

This is interesting, what is the use case, how such property is used?

The use case that has been described to us is the situation when the content, especially images, needs to be wrapped in a special container and labeled, to indicate the external source.

@Witoso Witoso added the domain:v4-compatibility This issue reports a CKEditor 4 feature/option that's missing in CKEditor 5. label Mar 11, 2024
@Mati365 Mati365 self-assigned this Jan 2, 2025
@Mati365 Mati365 mentioned this issue Jan 2, 2025
Merged
@CKEditorBot CKEditorBot added the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Jan 2, 2025
Mati365 added a commit that referenced this issue Jan 22, 2025
@Mati365
Add sourceEditorId property to clipboard input events. (#17707)
0eeccbe 
Feature (clipboard): Add ability to detect paste events originating from editor. Closes #15935
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Jan 22, 2025
@CKEditorBot CKEditorBot added this to the iteration 83 milestone Jan 22, 2025
@CKEditorBot CKEditorBot mentioned this issue Jan 23, 2025
Open
filipsobol pushed a commit that referenced this issue Jan 23, 2025
@Mati365 @filipsobol
Add sourceEditorId property to clipboard input events. (#17707)
c22457f 
Feature (clipboard): Add ability to detect paste events originating from editor. Closes #15935
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mati365 Mati365

Labels
domain:v4-compatibility This issue reports a CKEditor 4 feature/option that's missing in CKEditor 5. package:clipboard support:2 An issue reported by a commercially licensed client. type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
iteration 83
Development

Successfully merging a pull request may close this issue.

Add sourceEditorId property to clipboard input events. ckeditor/ckeditor5
4 participants
@Mati365 @Witoso @Mgsy @CKEditorBot