Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce an option to open file links embedded in CKEditor via CKBox in a new tab vs. downloading them #15928

Closed
mabryl opened this issue Feb 26, 2024 · 1 comment · Fixed by #17712
Assignees
Labels
intro Good first ticket. package:ckbox support:2 An issue reported by a commercially licensed client. type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Milestone

Comments

@mabryl
Copy link
Contributor

mabryl commented Feb 26, 2024

📝 Provide a description of the new feature

A client reached out to us via Zendesk searching for an option to open file links (PDFs in this case) in a new tab instead of the current default behavior which is to download the file.

Currently, when you insert a link into CKEditor that points to a file hosted in CKBox, the default behavior is to download the file.

A config option could be introduced that would allow users to set a different behavior for such file links: opening them in a new tab.

At the moment, it is possible to do so manually, like so:

  1. Upload a PDF into CKBox
  2. Open CKBox, select the file, click “Choose” to embed it in the editor
  3. Edit the link by removing the ?download=true part from the URL
  4. Click the link to open the PDF in a new tab

Quote from the customer:

I think most PDFs are viewed in the browser, so users are going to download the file, find it on their computer, and open it in the same browser they just downloaded from.

A UI option to toggle the download would be ideal, but I think the default behavior should be to not download PDFs. Other files that don't typically use a browser to render, maybe.


If you'd like to see this feature implemented, add a 👍 reaction to this post.

@mabryl mabryl added type:feature This issue reports a feature request (an idea for a new functionality or a missing option). support:2 An issue reported by a commercially licensed client. package:ckbox labels Feb 26, 2024
@Witoso Witoso added the intro Good first ticket. label Feb 26, 2024
@abd707rafiq
Copy link

Hello, I'm interested in contributing

@Mati365 Mati365 self-assigned this Jan 3, 2025
@CKEditorBot CKEditorBot added the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Jan 3, 2025
Mati365 added a commit that referenced this issue Jan 22, 2025
…7712)

Feature (ckbox): Allow to specify which files chosen from CKBox are downloadable. Closes #15928
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Jan 22, 2025
@CKEditorBot CKEditorBot added this to the iteration 83 milestone Jan 22, 2025
filipsobol pushed a commit that referenced this issue Jan 23, 2025
…7712)

Feature (ckbox): Allow to specify which files chosen from CKBox are downloadable. Closes #15928
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
intro Good first ticket. package:ckbox support:2 An issue reported by a commercially licensed client. type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants