Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selection is moved out of a table when touching/clicking in table cell with an image #1546

Closed
jodator opened this issue Feb 19, 2019 · 6 comments
Closed

Selection is moved out of a table when touching/clicking in table cell with an image #1546

jodator opened this issue Feb 19, 2019 · 6 comments
Labels
browser:android browser:chrome browser:firefox package:table resolution:duplicate This issue is a duplicate of another issue and was merged into it. type:bug This issue reports a buggy (incorrect) behavior.

Comments

@jodator
Copy link
Contributor

jodator commented Feb 19, 2019

Is this a bug report or feature request? (choose one)

🐞 Bug report

💻 Version of CKEditor

latest master

📋 Steps to reproduce

  1. create a table
  2. insert image
  3. optionally align image to left/rigth
  4. click in the table cell with an image

✅ Expected result

The selection is put in table cell before (or after) an image

❎ Actual result

The selection is moved to first element in root

📃 Other details that might be useful

  • Chrome on Android
  • Chrome on Ubuntu
  • Firefox on Ubuntu - the selection is set in right place (you can type in table cell) but is not rendered/visible
@f1ames
Copy link
Contributor

f1ames commented Feb 19, 2019

I have noticed very similar / same behaviour, when trying to focus table cell with widget:

Firefox:
ff issue1

In Firefox selection jumps between table cell with widget and cell after using mouse click on cell with widget.

Chrome:
chrome issue1

On Chrome selection moves to the first root element and @jodator described.

@Reinmar Reinmar closed this as completed Feb 20, 2019
@Reinmar
Copy link
Member

Reinmar commented Feb 20, 2019

Needs #407

@Reinmar Reinmar added the resolution:duplicate This issue is a duplicate of another issue and was merged into it. label Feb 20, 2019
@Reinmar Reinmar mentioned this issue Feb 20, 2019
Closed
@jodator
Copy link
Contributor Author

jodator commented Feb 20, 2019

@Reinmar but the problem is that selection is not set inside the table cell and I suspect some bug there. If you click other table cell with text only you can set the selection in there by clicking on table cell.

@jodator
Copy link
Contributor Author

jodator commented Feb 20, 2019

peek 2019-02-20 12-06

@Reinmar
Copy link
Member

Reinmar commented Feb 20, 2019

Are there any paragraphs where it can be set? Or just this media?

@jodator
Copy link
Contributor Author

jodator commented Feb 20, 2019

Only media.

@ma2ciek ma2ciek mentioned this issue Oct 11, 2019
Merged
pjasiun pushed a commit to ckeditor/ckeditor5-autosave that referenced this issue Oct 14, 2019
Merge pull request #27 from ckeditor/i/2546
d6079bf 
Feature: Provided error handling for save actions. Closes ckeditor/ckeditor5#1546.
@pjasiun pjasiun added this to the iteration 27 milestone Oct 14, 2019
@ma2ciek ma2ciek removed this from the iteration 27 milestone Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
browser:android browser:chrome browser:firefox package:table resolution:duplicate This issue is a duplicate of another issue and was merged into it. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Reinmar @jodator @f1ames @pjasiun @ma2ciek