Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failure on installation for node 20+ #15203

Closed
Witoso opened this issue Oct 19, 2023 · 1 comment · Fixed by ckeditor/ckeditor5-linters-config#26
Closed

Failure on installation for node 20+ #15203

Witoso opened this issue Oct 19, 2023 · 1 comment · Fixed by ckeditor/ckeditor5-linters-config#26
Assignees
@pomek
Labels
squad:devops Issue to be handled by the Devops team. type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 68 (v40...

Comments

@Witoso
Copy link
Member

Witoso commented Oct 19, 2023

📝 Provide detailed reproduction steps (if any)

Node v20 is the current active LTS, our engine allows >=18.

  1. Make sure your node is in 20+ version
  2. Launch yarn reinstall in ckeditor5 repo.

✔️ Expected result

Install works correctly.

❌ Actual result

error @es-joy/[email protected]: The engine "node" is incompatible with this module. Expected version "^14 || ^16 || ^17 || ^18 || ^19". Got "20.8.1"

❓ Possible solution

yarn why @es-joy/jsdoccomment
=> Found "@es-joy/[email protected]"
info Reasons this module exists
   - "_project_#eslint-config-ckeditor5#eslint-plugin-ckeditor5-rules" depends on it
   - Hoisted from "_project_#eslint-config-ckeditor5#eslint-plugin-ckeditor5-rules#@es-joy#jsdoccomment"

If you'd like to see this fixed sooner, add a 👍 reaction to this post.
@Witoso Witoso added type:bug This issue reports a buggy (incorrect) behavior. squad:devops Issue to be handled by the Devops team. squad:core Issue to be handled by the Core team. labels Oct 19, 2023
@pomek
Copy link
Member

pomek commented Oct 19, 2023

Let's see if upgrading https://github.com/ckeditor/ckeditor5-linters-config/blob/7852374add49fe23c9f7a436d7f119b35f5c6aa0/packages/eslint-plugin-ckeditor5-rules/package.json#L40 to the latest version helps.

@pomek pomek mentioned this issue Oct 19, 2023
Merged
@pomek pomek removed the squad:core Issue to be handled by the Core team. label Oct 19, 2023
@pomek pomek self-assigned this Oct 19, 2023
@CKEditorBot CKEditorBot added the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Oct 19, 2023
psmyrek added a commit to ckeditor/ckeditor5-linters-config that referenced this issue Oct 20, 2023
@psmyrek
Merge pull request #26 from ckeditor/ck/15203-jsdoccomment
cc93260 
Other (eslint-plugin-ckeditor5-rules): Upgrade the `@es-joy/jsdoccomment` package to its latest version to make the CKEditor 5 compatible with Node@20. Closes ckeditor/ckeditor5#15203.
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Oct 20, 2023
@CKEditorBot CKEditorBot added this to the iteration 68 milestone Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pomek pomek

Labels
squad:devops Issue to be handled by the Devops team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 68 (v40.1.0)
Development

Successfully merging a pull request may close this issue.

Upgrade to the latest version "@es-joy/jsdoccomment" ckeditor/ckeditor5-linters-config
3 participants
@pomek @Witoso @CKEditorBot