Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PoC for image attributes #15185

Closed
Witoso opened this issue Oct 16, 2023 · 0 comments · Fixed by #15222
Closed

PoC for image attributes #15185

Witoso opened this issue Oct 16, 2023 · 0 comments · Fixed by #15222
Assignees
@niegowski
Labels
domain:framework-dx This issue reports a problem with the developer experience while working with the framework. follow-up:how-to package:image squad:core Issue to be handled by the Core team.
Milestone
iteration 68 (v40...

Comments

@Witoso
Copy link
Member

Witoso commented Oct 16, 2023 •
edited
Loading

Prepare a PoC how could show using the new image attributes after the recent changes (#14146).

  • no usage of style attributes in the data.
  • data downcast saves in attributes width and height a resized image values.
  • on upcast, width and height are set as resized*.
  • add attributes with intrinsic size width and height.
@Witoso Witoso added squad:core Issue to be handled by the Core team. package:image follow-up:how-to domain:framework-dx This issue reports a problem with the developer experience while working with the framework. labels Oct 16, 2023
@CKEditorBot CKEditorBot added the status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. label Oct 18, 2023
@niegowski niegowski self-assigned this Oct 20, 2023
@CKEditorBot CKEditorBot added status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. and removed status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. labels Oct 20, 2023
@niegowski niegowski mentioned this issue Oct 23, 2023
Merged
niegowski added a commit that referenced this issue Oct 27, 2023
@niegowski
Merge pull request #15222 from ckeditor/ck/15185
6e60e0b 
Internal (image): Added manual test with overridden image conversion to use only size attributes for images. Closes #15185.
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Oct 27, 2023
@CKEditorBot CKEditorBot added this to the iteration 68 milestone Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niegowski niegowski

Labels
domain:framework-dx This issue reports a problem with the developer experience while working with the framework. follow-up:how-to package:image squad:core Issue to be handled by the Core team.
Projects
None yet
Milestone
iteration 68 (v40.1.0)
Development

Successfully merging a pull request may close this issue.

Manual test with simple image ckeditor/ckeditor5
3 participants
@niegowski @Witoso @CKEditorBot