Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Drag & Drop] Preview logic requires tweaking. #14968

Closed
Tracked by #13933
Witoso opened this issue Sep 11, 2023 · 0 comments · Fixed by #14983
Closed
Tracked by #13933

[Drag & Drop] Preview logic requires tweaking. #14968

Witoso opened this issue Sep 11, 2023 · 0 comments · Fixed by #14983
Assignees
@illia-stv
Labels
squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 67 (v40...

Comments

@Witoso
Copy link
Member

Witoso commented Sep 11, 2023

📝 Provide detailed reproduction steps (if any)

Fix the logic:

  1. When selected above the block toolbar ⇒ above the editable.
    1. This works now, we may check if the implementation in the experimental is correct.
  2. When in the editable, show preview near the cursor.

Otherwise, in some cases, the preview won't be visible.

Nagranie.z.ekranu.2023-07-11.o.16.51.20.mov

If you'd like to see this fixed sooner, add a 👍 reaction to this post.
@Witoso Witoso added the type:bug This issue reports a buggy (incorrect) behavior. label Sep 11, 2023
@Witoso Witoso mentioned this issue Sep 11, 2023
Closed
16 tasks
@Witoso Witoso added the squad:core Issue to be handled by the Core team. label Sep 11, 2023
@CKEditorBot CKEditorBot added the status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. label Sep 11, 2023
@illia-stv illia-stv self-assigned this Sep 11, 2023
@illia-stv illia-stv added status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. and removed status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. labels Sep 11, 2023
@pszczesniak pszczesniak mentioned this issue Sep 13, 2023
Closed
@illia-stv illia-stv mentioned this issue Sep 13, 2023
Merged
niegowski added a commit that referenced this issue Sep 15, 2023
@niegowski
Merge pull request #14983 from ckeditor/ck/14968-preview-logic-requir…
905f480 
…es-tweaking

Fix (clipboard): improve displaying preview in "drag and drop". Closes #14968.
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Sep 15, 2023
@CKEditorBot CKEditorBot added this to the iteration 67 milestone Sep 15, 2023
@CKEditorBot CKEditorBot mentioned this issue Sep 16, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@illia-stv illia-stv

Labels
squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 67 (v40.0.0)
Development

Successfully merging a pull request may close this issue.

Preview logic requires tweaking ckeditor/ckeditor5
3 participants
@Witoso @CKEditorBot @illia-stv