Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade the minimal required Node.js version to 18 #14924

Closed
pomek opened this issue Sep 4, 2023 · 3 comments
Closed

Upgrade the minimal required Node.js version to 18 #14924

pomek opened this issue Sep 4, 2023 · 3 comments
Assignees
@przemyslaw-zan
Labels
squad:platform Issue to be handled by the Platform team. type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 67 (v40...

Comments

@pomek
Copy link
Member

pomek commented Sep 4, 2023 •
edited
Loading

Provide a description of the task

Why

What

  • Upgrade the minimal requested version of Node.js.
  • Currently, we require Node@16. Upgrade it to Node@18.
  • In CKEditor 5, it's a change for developers integrating the ckeditor/ckeditor5 repository only.
  • In repositories using Node.js (ckeditor5-dev, mrgit, etc.), it's a breaking change requiring bumping the major version.
  • In the docs repository, do not forget about bumping the Node.js version in Dockerfile.
  • Could we drop the node-fetch package in favor of the built-in function?

Before start

  • Talk to CERD (@jacekbogdanski) about whether they support Node@18. If you need more clarification, ask to verify, as the documentation builder will require Node 18 soon. Perhaps @vokiel could help.
@pomek pomek added type:task This issue reports a chore (non-production change) and other types of "todos". squad:platform Issue to be handled by the Platform team. labels Sep 4, 2023
@CKEditorBot CKEditorBot added the status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. label Sep 11, 2023
@przemyslaw-zan przemyslaw-zan self-assigned this Sep 12, 2023
@CKEditorBot CKEditorBot added status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. and removed status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. labels Sep 12, 2023
This was referenced Sep 13, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
pomek added a commit to ckeditor/ckeditor5-linters-config that referenced this issue Sep 14, 2023
@pomek
Merge pull request #25 from ckeditor/ck/14924
7852374 
Other: Updated the required version of Node.js to 18 when developing the repository. See ckeditor/ckeditor5#14924.
pomek added a commit to cksource/mrgit that referenced this issue Sep 14, 2023
@pomek
Merge pull request #165 from cksource/ck/14924
fd5d80a 
Other: Updated the required version of Node.js to 18. See ckeditor/ckeditor5#14924.

MAJOR BREAKING CHANGE: Upgraded the minimal versions of Node.js to `18.0.0` due to the end of LTS.
pomek added a commit that referenced this issue Sep 15, 2023
@pomek
Merge pull request #14989 from ckeditor/ck/14924
d8c967b 
Other: Updated the required version of Node.js to 18 for the development environment. See #14924.
pomek added a commit to ckeditor/ckeditor5-package-generator that referenced this issue Sep 15, 2023
@pomek
Merge pull request #164 from ckeditor/ck/14924
6842056 
Other: Updated the required version of Node.js to 18. See ckeditor/ckeditor5#14924.

MAJOR BREAKING CHANGE: Upgraded the minimal versions of Node.js to `18.0.0` due to the end of LTS.
pomek added a commit to ckeditor/ckeditor5-vue2 that referenced this issue Sep 15, 2023
@pomek
Merge pull request #44 from ckeditor/ck/14924
0596fd9 
Other: Updated the required version of Node.js to 18 when developing the repository. See ckeditor/ckeditor5#14924.
pomek added a commit to ckeditor/ckeditor5-vue that referenced this issue Sep 15, 2023
@pomek
Merge pull request #258 from ckeditor/ck/14924
7c2ed35 
Other: Updated the required version of Node.js to 18 when developing the repository. See ckeditor/ckeditor5#14924.
pomek added a commit to ckeditor/ckeditor5-react that referenced this issue Sep 15, 2023
@pomek
Merge pull request #412 from ckeditor/ck/14924
9998e47 
Other: Updated the required version of Node.js to 18 when developing the repository. See ckeditor/ckeditor5#14924.
pomek added a commit to ckeditor/ckeditor5-angular that referenced this issue Sep 15, 2023
@pomek
Merge pull request #389 from ckeditor/ck/14924
693e01c 
Other: Updated the required version of Node.js to 18 when developing the repository. See ckeditor/ckeditor5#14924.
pomek added a commit to ckeditor/ckeditor5-inspector that referenced this issue Sep 15, 2023
@pomek
Merge pull request #179 from ckeditor/ck/14924
ed7eaaa 
Other: Updated the required version of Node.js to 18 when developing the repository. See ckeditor/ckeditor5#14924.
pomek added a commit to ckeditor/ckeditor5-dev that referenced this issue Sep 15, 2023
@pomek
Merge pull request #921 from ckeditor/ck/14924
61c03cd 
Other: Updated the required version of Node.js to 18. See ckeditor/ckeditor5#14924.

MAJOR BREAKING CHANGE: Upgraded the minimal versions of Node.js to `18.0.0` due to the end of LTS.
@pomek
Copy link
Member Author

pomek commented Sep 15, 2023

  • Could we drop the node-fetch package in favor of the built-in function?

We decided to leave the current scripts as they are to avoid potential issues using an experimental API.

Source: https://nodejs.org/dist/latest-v18.x/docs/api/globals.html#fetch.

@pomek
Copy link
Member Author

pomek commented Sep 15, 2023

The ckeditor5-dev-* packages are released as https://github.com/ckeditor/ckeditor5-dev/releases/tag/v39.0.0.

Bump in CKE5: 877a98e. CC is covered too.

@pomek
Copy link
Member Author

pomek commented Sep 15, 2023

I am closing this issue as all CKEditor 5 repositories/packages are aligned to Node@18.

The remaining PRs are tracked in an internal issue.

@pomek pomek closed this as completed Sep 15, 2023
@pomek pomek added this to the iteration 67 milestone Sep 15, 2023
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Sep 15, 2023
@CKEditorBot CKEditorBot mentioned this issue Sep 16, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@przemyslaw-zan przemyslaw-zan

Labels
squad:platform Issue to be handled by the Platform team. type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 67 (v40.0.0)
Development

No branches or pull requests
3 participants
@pomek @CKEditorBot @przemyslaw-zan