"npm run clean-up-svg-icons" ignores input parameters

[timothydavis]

Origin URL

https://ckeditor.com/docs/ckeditor5/latest/framework/contributing/development-environment.html

Project version

39.0.1

Is the information outdated? How?

The clean-up-svg-icons package doesn't seem to exist. cleanup-svg-icons uses an old library and no longer works.

Can you look at what is a proper way to exclude SVG checks perhaps or clean these up?

Is there something missing in the guide? What is it?

No response

Is there anything else you would like to add?

No response

User agent

Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/116.0.0.0 Safari/537.36

[Witoso]

@pomek do you know something about this script or an alternative?

[pomek]

The clean-up-svg-icons script was recently rewritten from its bash version to Node.js syntax.

ckeditor5/scripts/clean-up-svg-icons.js

Line 53 in 8d8a573

execSync( `svgo --config=./scripts/svgo.config.js -i ${ pathToIcon }` );

Unfortunately, we weren't aware that our docs use it too. Currently, there is no option to pass a single icon to optimize. It sounds like a feature request in the new tool or a bug fix - restore what we removed during the migration.

Scope

• When running the clean-up-svg-icons script with no arguments, process all SVG icons.
• When specified paths (glob patterns or paths), use the input and process only mentioned files.
  • npm run clean-up-svg-icons packages/ckeditor5-core/theme/icons/*.svg - process all Core icons
  • npm run clean-up-svg-icons packages/ckeditor5-core/theme/icons/*.svg packages/ckeditor5-basic-styles/eme/icons/bold.svg - process all Core icons and Bold from basic-style