Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Drag & drop] Upload image issues #14740

Closed
Tracked by #13933
Witoso opened this issue Aug 3, 2023 · 2 comments · Fixed by #14986
Closed
Tracked by #13933

[Drag & drop] Upload image issues #14740

Witoso opened this issue Aug 3, 2023 · 2 comments · Fixed by #14986
Assignees
Labels
squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.

Comments

@Witoso
Copy link
Member

Witoso commented Aug 3, 2023

📝 Provide detailed reproduction steps (if any)

❌ dropping an image to the table from the external source doesn’t work if you want to drop the image below or above the code block (but the drop target line is visible).

❌ when you want to drop an image under or above text or block quote, the image appears inline (even if the drop target line is visible).

  • the logic if it's inline or block should be joined with the pasting of images. Initial logic: paragraph with text, always inline, etc.
Nagranie.z.ekranu.2023-07-12.o.13.46.12.mov

If you'd like to see this fixed sooner, add a 👍 reaction to this post.

@Witoso Witoso added type:bug This issue reports a buggy (incorrect) behavior. squad:core Issue to be handled by the Core team. labels Aug 3, 2023
@Witoso Witoso mentioned this issue Aug 3, 2023
16 tasks
@CKEditorBot CKEditorBot added the status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. label Sep 11, 2023
@illia-stv illia-stv self-assigned this Sep 15, 2023
@CKEditorBot CKEditorBot added status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. and removed status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. labels Sep 15, 2023
@illia-stv
Copy link
Contributor

This issue is resolved by another PR: #14986
So after merging it could be closed

@Witoso
Copy link
Member Author

Witoso commented Sep 15, 2023

AFAIK @illia-stv you can close two issues with one PR.

arkflpc added a commit that referenced this issue Sep 18, 2023
…ge-if-dropped-bellow

Fix (image): Image should not be replaced when dropped below a widget. Closes #14710. Closes #14740.
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Sep 18, 2023
@CKEditorBot CKEditorBot added this to the iteration 67 milestone Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants