Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image size attributes and picture (art direction) #14532

Closed
Tracked by #14146
mmotyczynska opened this issue Jul 4, 2023 · 1 comment
Closed
Tracked by #14146

Image size attributes and picture (art direction) #14532

mmotyczynska opened this issue Jul 4, 2023 · 1 comment
Assignees
@mmotyczynska
Labels
package:image squad:core Issue to be handled by the Core team. type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 67 (v40...

Comments

@mmotyczynska
Copy link
Contributor

Provide a description of the task

Inline image (picture) doesn't look good with current ck-content styles if it is not resized. The output shows a much larger image compared to the editor content.

image

To re-create the issue:

  1. Open http://localhost:8125/ckeditor5-image/tests/manual/imagesizeattributesallcases.html manual test.
  2. For the first editor set data:
<p><picture><source srcset="logo-square.png" media="(max-width: 800px)" type="image/png"><source srcset="logo-wide.png" media="(min-width: 800px)" type="image/png"><img class="image_resized" style="width:250px;" src="logo-wide.png" alt="Alt text of the block image."></picture></p>
  1. Shrink the browser so the images are small enough to see the difference.

📃 Other details

  • Browser: …
  • OS: …
  • CKEditor version: …
  • Installed CKEditor plugins: …
@mmotyczynska mmotyczynska added type:task This issue reports a chore (non-production change) and other types of "todos". package:image squad:core Issue to be handled by the Core team. labels Jul 4, 2023
@mmotyczynska mmotyczynska self-assigned this Jul 4, 2023
@CKEditorBot CKEditorBot added the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Jul 4, 2023
@mmotyczynska mmotyczynska mentioned this issue Jul 5, 2023
Merged
@mmotyczynska
Copy link
Contributor Author

We decided not to restrict the width in output data in this case. But keep the use cases in manual test, they will be useful when testing next changes for image sizes.

mmotyczynska added a commit that referenced this issue Jul 7, 2023
@mmotyczynska
Merge pull request #14534 from ckeditor/ck/14532-image-sizes-and-picture
c249d94 
Task (image): Adds picture use cases to image sizes manual test. Closes #14532.
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Jul 7, 2023
@CKEditorBot CKEditorBot added this to the upcoming milestone Jul 7, 2023
@Witoso Witoso mentioned this issue Jul 12, 2023
Closed
10 tasks
@CKEditorBot CKEditorBot modified the milestones: upcoming, iteration 67 Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mmotyczynska mmotyczynska

Labels
package:image squad:core Issue to be handled by the Core team. type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 67 (v40.0.0)
Development

No branches or pull requests
2 participants
@CKEditorBot @mmotyczynska