Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Information about the error in input is not correctly announced by screen reader #1406

Closed
Comandeer opened this issue Dec 11, 2018 · 0 comments · Fixed by ckeditor/ckeditor5-ui#518
Closed

Information about the error in input is not correctly announced by screen reader #1406

Comandeer opened this issue Dec 11, 2018 · 0 comments · Fixed by ckeditor/ckeditor5-ui#518
Assignees
@msamsel
Labels
domain:accessibility This issue reports an accessibility problem. package:media-embed package:ui type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 26

Comments

@Comandeer
Copy link
Member

Is this a bug report or feature request? (choose one)

🐞 Bug report

💻 Version of CKEditor

https://ckeditor.com/docs/ckeditor5/latest/examples/builds/classic-editor.html

📋 Steps to reproduce

  1. Launch screen reader.
  2. Click "Insert media" button.
  3. Type incorrect URL, e.g. "hublabubla" or just left the input empty.
  4. Press Enter.

✅ Expected result

The screen reader reads the error message.

❎ Actual result

The screen reader only informs that field is invalid.

📃 Other details that might be useful

Tested in VoiceOver. Probably the issue is connected with the fact that element containing the error does not have appropriate [aria-live] or [role] attribute.
@oleq oleq added type:bug This issue reports a buggy (incorrect) behavior. status:confirmed package:ui package:media-embed labels Dec 11, 2018
@oleq oleq mentioned this issue Dec 11, 2018
Closed
@oleq oleq added the module:ux label Dec 11, 2018
@Reinmar Reinmar added this to the next milestone Mar 25, 2019
@msamsel msamsel mentioned this issue Jul 5, 2019
Merged
@mlewand mlewand added the domain:accessibility This issue reports an accessibility problem. label Jul 12, 2019
@mlewand mlewand modified the milestones: next, iteration 26 Jul 12, 2019
mlewand added a commit to ckeditor/ckeditor5-ui that referenced this issue Jul 12, 2019
@mlewand
Fix: Screen reader will now properly prompt errors for text inputs. C…
3a164b7 
…loses ckeditor/ckeditor5#1406.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@msamsel msamsel

Labels
domain:accessibility This issue reports an accessibility problem. package:media-embed package:ui type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 26
Development

Successfully merging a pull request may close this issue.

Add role="alert" to error notification in label input view ckeditor/ckeditor5-ui
5 participants
@Reinmar @Comandeer @oleq @mlewand @msamsel