Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong tooltip when hovering toolbar buttons on Chrome on iOS #13812

Closed
FilipTokarski opened this issue Apr 3, 2023 · 0 comments · Fixed by #14699
Closed

Wrong tooltip when hovering toolbar buttons on Chrome on iOS #13812

FilipTokarski opened this issue Apr 3, 2023 · 0 comments · Fixed by #14699
Assignees
@illia-stv
Labels
domain:accessibility This issue reports an accessibility problem. domain:ui/ux This issue reports a problem related to UI or UX. intro Good first ticket. package:utils squad:core Issue to be handled by the Core team. support:2 An issue reported by a commercially licensed client. type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 67 (v40...

Comments

@FilipTokarski
Copy link
Member

📝 Provide detailed reproduction steps (if any)

  1. Connect external keyboard to an iPad.
  2. Open Chrome browser.
  3. Go to online demo.
  4. Focus the toolbar and navigate buttons until you reach bold.

✔️ Expected result

Tooltip shows Bold (⌘B).

❌ Actual result

Tooltip shows Bold (Ctrl+B).

❓ Possible solution

Extend checks in utils package:

env.isMac || env.isiOS instead of env.isMac.

📃 Other details

  • Browser: …
  • OS: …
  • First affected CKEditor version: …
  • Installed CKEditor plugins: …

If you'd like to see this fixed sooner, add a 👍 reaction to this post.
@FilipTokarski FilipTokarski added type:bug This issue reports a buggy (incorrect) behavior. package:utils domain:ui/ux This issue reports a problem related to UI or UX. support:2 An issue reported by a commercially licensed client. domain:accessibility This issue reports an accessibility problem. squad:core Issue to be handled by the Core team. labels Apr 3, 2023
@mlewand mlewand added intro Good first ticket. squad:features Issue to be handled by the Features team. and removed squad:core Issue to be handled by the Core team. labels Jul 27, 2023
@CKEditorBot CKEditorBot added the status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. label Jul 27, 2023
@illia-stv illia-stv self-assigned this Jul 31, 2023
@CKEditorBot CKEditorBot added status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. and removed status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. labels Jul 31, 2023
@illia-stv illia-stv mentioned this issue Jul 31, 2023
Merged
@CKEditorBot CKEditorBot added status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. and removed status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. labels Aug 4, 2023
@Witoso Witoso added squad:core Issue to be handled by the Core team. and removed squad:features Issue to be handled by the Features team. labels Aug 22, 2023
arkflpc added a commit that referenced this issue Sep 6, 2023
@arkflpc
Merge pull request #14699 from ckeditor/ck/13812-wrong-tooltip-when-h…
5c7fe1c 
…overing-buttons-on-chrome-on-ios

Fix (utils): Wrong tooltip when hovering toolbar buttons on Chrome on iOS. Closes #13812.
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Sep 6, 2023
@CKEditorBot CKEditorBot added this to the iteration 67 milestone Sep 6, 2023
@CKEditorBot CKEditorBot mentioned this issue Sep 7, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@illia-stv illia-stv

Labels
domain:accessibility This issue reports an accessibility problem. domain:ui/ux This issue reports a problem related to UI or UX. intro Good first ticket. package:utils squad:core Issue to be handled by the Core team. support:2 An issue reported by a commercially licensed client. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 67 (v40.0.0)
Development

Successfully merging a pull request may close this issue.

Wrong tooltip when hovering toolbar buttons on Chrome on iOS ckeditor/ckeditor5
5 participants
@mlewand @Witoso @CKEditorBot @FilipTokarski @illia-stv