-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unclear whether we can use imports from index.js files of core (DLL) packages? #10375
Unclear whether we can use imports from index.js files of core (DLL) packages? #10375
Comments
Core DLL packages can import between themselves using any import condition.
|
There's a history behind the inconsistency. The problem is that core DLL packages may want to import something from another core DLL package that is not exposed in Let's create a rule checking for that. And document the "why" briefly in the documentation introduced in #10051. Finally, create a followup to check what kind of imports between core DLL packages block us from moving to |
PRs:
|
Docs: Mention imports between DLLs packages. See #10375.
Other: An import between DLL packages must use the full name of the imported package. Closes ckeditor/ckeditor5#10375.
See:
Originally posted by @Reinmar in #10352 (comment)
The below change does not trigger a linter warning, so it's unclear to me how the code should be written:
The text was updated successfully, but these errors were encountered: