Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It's impossible to focus the toolbar with the keyboard in the source editing mode #10368

Closed
Mgsy opened this issue Aug 17, 2021 · 2 comments · Fixed by #12064
Closed

It's impossible to focus the toolbar with the keyboard in the source editing mode #10368

Mgsy opened this issue Aug 17, 2021 · 2 comments · Fixed by #12064
Assignees
Labels
domain:accessibility This issue reports an accessibility problem. package:source-editing squad:features Issue to be handled by the Features team. type:improvement This issue reports a possible enhancement of an existing feature.

Comments

@Mgsy
Copy link
Member

Mgsy commented Aug 17, 2021

📝 Provide a description of the improvement

  1. Use the keyboard to enter the source editing mode.
  2. Focus on the editable and type something.
  3. Try to move back to the toolbar with the keyboard.

Related - #9906.


If you'd like to see this improvement implemented, add a 👍 reaction to this post.

@Mgsy Mgsy added type:improvement This issue reports a possible enhancement of an existing feature. domain:accessibility This issue reports an accessibility problem. squad:compat package:source-editing labels Aug 17, 2021
@Reinmar Reinmar added squad:core Issue to be handled by the Core team. and removed squad:compat labels Sep 27, 2021
@mlewand mlewand added squad:features Issue to be handled by the Features team. and removed squad:core Issue to be handled by the Core team. labels Sep 29, 2021
@mlewand
Copy link
Contributor

mlewand commented Jun 1, 2022

The poorman's solution would be simply to add alt+f10 handling for source editing plugin.

Now, the better idea would be to improve keystroke handler so that the keystrokes (hotkeys) could specify a context where a given keystroke is viable.

This way toolbar focus could be registered like:

editor.keystrokes.set( { keystroke: 'Ctrl+E', callback: ( data, cancel ) => {
    // logic goes here

}, context: "all" } );

And for instance keystrokes that make sense only in editable would be registered like that:

editor.keystrokes.set( { keystroke: 'Ctrl+E', command: 'bold', context: "editable" } );

Having that said let's go with poorman's solution as long as we don't have other cases that would benefit from contexts.

@mateuszzagorski mateuszzagorski self-assigned this Jun 2, 2022
@CKEditorBot CKEditorBot added the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Jun 2, 2022
@wimleers
Copy link

Sounds good! 👍

FYI: tracking this at https://www.drupal.org/project/drupal/issues/3283800 😊

@CKEditorBot CKEditorBot added status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. and removed status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. labels Jun 21, 2022
@CKEditorBot CKEditorBot added status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. and removed status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. labels Jul 18, 2022
oleq added a commit that referenced this issue Aug 22, 2022
…-toolbar-v2

Feature (core): Enabled toolbar focusing and navigation across various editor implementations and features. Closes #10368. Closes #5146. Closes #9906. Closes #10025.

BREAKING CHANGE (ui): The `enableToolbarKeyboardFocus()` helper has been removed. Please use the [`EditorUI#addToolbar()`](https://ckeditor.com/docs/ckeditor5/latest/api/module_core_editor_editorui-EditorUI.html#function-addToolbar) method instead to enable accessible toolbar navigation (and focusing) using `Alt+F10` and `Esc` keystrokes (see #10368).
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Aug 22, 2022
@CKEditorBot CKEditorBot added this to the iteration 56 milestone Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:accessibility This issue reports an accessibility problem. package:source-editing squad:features Issue to be handled by the Features team. type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
7 participants