-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toolbar button labels not read by screen readers #1013
Comments
cc @oleq |
I created a general issue for accessibility but to bootstrap the huge task in the spirit of progressive enhancement I also proposed a simple PR which makes the buttons in the toolbar a little bit more a11y–friendly. Could you check it out, @Kataract? |
@oleq I apparently turned off my notifications and didn't see this until now, sorry 🙃 That should take care of it - thanks! |
Fix: The buttons in the editor should provide basic accessibility. Closes ckeditor/ckeditor5#1013.
This issue seems to persist while using VoiceOver on Chrome/Mac. Screen reader doesn't read the toolbar option label, only the element type (button). |
I'm just building a website with Drupal, where I'm using CK editor 5. and same happening with me. most of the buttons are without lable. only "button". |
Is this a bug report or feature request? (choose one)
🐞 Bug report
💻 Version of CKEditor
CKEditor 5 Builds
📋 Steps to reproduce
✅ Expected result
Screen readers should announce what each button does (bold, italic, link, etc)
❎ Actual result
Screen reader only announces "button"
📃 Other details that might be useful
The
.ck-button__label
class usesdisplay: none;
which hides the label from assistive technologies. Changing todisplay: block;
and using another way of hiding the label visually re-surfaces this for AT, and the labels get read out again.Link on different ways to hide text visually but still have it "visible" to AT: https://webaim.org/techniques/css/invisiblecontent/#techniques
The text was updated successfully, but these errors were encountered: