Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolbar button labels not read by screen readers #1013

Closed
Kataract opened this issue May 7, 2018 · 5 comments
Closed

Toolbar button labels not read by screen readers #1013

Kataract opened this issue May 7, 2018 · 5 comments
Labels
domain:accessibility This issue reports an accessibility problem. type:bug This issue reports a buggy (incorrect) behavior.
Milestone

Comments

@Kataract
Copy link

Kataract commented May 7, 2018

Is this a bug report or feature request? (choose one)

🐞 Bug report

💻 Version of CKEditor

CKEditor 5 Builds

📋 Steps to reproduce

  1. With a screen reader active, enter the text area and hit alt+f10 to get in to the toolbar
  2. Use the arrow keys to navigate toolbar options

✅ Expected result

Screen readers should announce what each button does (bold, italic, link, etc)

❎ Actual result

Screen reader only announces "button"

📃 Other details that might be useful

The .ck-button__label class uses display: none; which hides the label from assistive technologies. Changing to display: block; and using another way of hiding the label visually re-surfaces this for AT, and the labels get read out again.

Link on different ways to hide text visually but still have it "visible" to AT: https://webaim.org/techniques/css/invisiblecontent/#techniques

@Reinmar
Copy link
Member

Reinmar commented May 14, 2018

cc @oleq

@oleq
Copy link
Member

oleq commented May 23, 2018

I created a general issue for accessibility but to bootstrap the huge task in the spirit of progressive enhancement I also proposed a simple PR which makes the buttons in the toolbar a little bit more a11y–friendly. Could you check it out, @Kataract?

@Kataract
Copy link
Author

Kataract commented Jun 3, 2018

@oleq I apparently turned off my notifications and didn't see this until now, sorry 🙃

That should take care of it - thanks!

Reinmar added a commit to ckeditor/ckeditor5-ui that referenced this issue Jun 13, 2018
Fix: The buttons in the editor should provide basic accessibility. Closes ckeditor/ckeditor5#1013.
@Reinmar Reinmar added this to the iteration 18 milestone Jun 13, 2018
@Reinmar Reinmar added type:bug This issue reports a buggy (incorrect) behavior. status:confirmed labels Jun 13, 2018
@Reinmar Reinmar added the domain:accessibility This issue reports an accessibility problem. label Dec 3, 2019
@marjon4
Copy link

marjon4 commented Oct 13, 2021

This issue seems to persist while using VoiceOver on Chrome/Mac. Screen reader doesn't read the toolbar option label, only the element type (button).

@AbdullahZubair
Copy link

I'm just building a website with Drupal, where I'm using CK editor 5. and same happening with me. most of the buttons are without lable. only "button".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:accessibility This issue reports an accessibility problem. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

No branches or pull requests

5 participants