Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept imports from the ckeditor5 package from src/ directory only #10030

Closed
pomek opened this issue Jul 1, 2021 · 1 comment · Fixed by ckeditor/eslint-plugin-ckeditor5-rules#6
Closed

Accept imports from the ckeditor5 package from src/ directory only #10030

pomek opened this issue Jul 1, 2021 · 1 comment · Fixed by ckeditor/eslint-plugin-ckeditor5-rules#6
Assignees
@pomek
Labels
squad:platform Issue to be handled by the Platform team. type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 45 (v29...

Comments

@pomek
Copy link
Member

pomek commented Jul 1, 2021

📝 Provide detailed reproduction steps (if any)

See: 0b9e98f

import 'ckeditor5/packages/ckeditor5-ui/theme/components/responsive-form/responsiveform.css';

The snippet above uses the wrong path. Even if it works on our local machines, it will not work when integrators create a custom build, and all packages will be installed from npm.
@pomek pomek added type:bug This issue reports a buggy (incorrect) behavior. squad:platform Issue to be handled by the Platform team. labels Jul 1, 2021
@pomek pomek added this to the iteration 44 milestone Jul 1, 2021
@pomek pomek self-assigned this Jul 1, 2021
@pomek
Copy link
Member Author

pomek commented Jul 1, 2021

ESlint should prevent writing such paths.

@pomek pomek mentioned this issue Jul 1, 2021
Merged
@Reinmar Reinmar modified the milestones: iteration 44, Iteration 45 Jul 4, 2021
mlewand added a commit to ckeditor/eslint-plugin-ckeditor5-rules that referenced this issue Jul 5, 2021
@mlewand
Merge pull request #6 from ckeditor/ck/10030
d120742 
Fix: Disallow importing from other directories than "src/" when importing from the "ckeditor5" package. Closes ckeditor/ckeditor5#10030.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pomek pomek

Labels
squad:platform Issue to be handled by the Platform team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 45 (v29.1.0)
2 participants
@Reinmar @pomek