Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename exports back to CkeditorPlugin and Ckeditor. #292

Merged
merged 3 commits into from
Jul 16, 2024

Conversation

filipsobol
Copy link
Member

@filipsobol filipsobol commented Jul 15, 2024

Suggested merge commit message (convention)

Other: Rename exports to improve name of the editor component in Vue.

MINOR BREAKING CHANGE: Rename main package exports to CkeditorPlugin and Ckeditor.


Additional information

This changes the names of the exports introduced in v7.0.0-alpha.0 from CKEditorPlugin and CKEditor to CkeditorPlugin and Ckeditor. This is caused by how Vue handles components with capitalized names. The component with more than one consecutive capital letter will also be be available in kebab-case, where each capital letter is separated by -. This way, the CKEditor component was available as c-k-editor, which doesn't look good.
After this change, the component will be available as Ckeditor or ckeditor.

@coveralls
Copy link

coveralls commented Jul 15, 2024

Pull Request Test Coverage Report for Build 839f907c-7cb5-4a81-a128-9607d7cb417f

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build fd404117-a8e6-4497-9da6-6e7b987abba8: 0.0%
Covered Lines: 57
Relevant Lines: 57

💛 - Coveralls

@pomek pomek requested a review from psmyrek July 15, 2024 11:55
@pomek pomek merged commit fac4482 into master Jul 16, 2024
3 checks passed
@pomek pomek deleted the revert-renames-of-exports branch July 16, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants