Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

i/6188: The uid() helper should be a lot faster #322

Merged
merged 2 commits into from
Feb 4, 2020
Merged

i/6188: The uid() helper should be a lot faster #322

merged 2 commits into from
Feb 4, 2020

Conversation

oleq
Copy link
Member

@oleq oleq commented Feb 4, 2020

Suggested merge commit message (convention)

Internal: The uid() helper should be a lot faster. Closes ckeditor/ckeditor5#6188.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 2fa4510 on i/6188 into e63b7b7 on master.

@Reinmar
Copy link
Member

Reinmar commented Feb 4, 2020

Since we were working on it in the context of ckeditor/ckeditor5#6161 (comment) I'd like to know its effect on that scenario. Could you compare before/after performance of loading that UI?

@oleq
Copy link
Member Author

oleq commented Feb 4, 2020

Nothing spectacular. Around 35ms on total 350ms when switching categories from Arrows->All (~10%).

Then I checked the http://localhost:8125/ckeditor5/tests/manual/performance/richeditor.html test and I created the editor on button click. The difference is 965ms vs 895ms (around 7%).

It's not like the editor is blazingly fast now but this is something.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The uid() helper is sluggish and can be improved
3 participants