This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
T/262: Implemented View#render method #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…named addChildren(), removeChildren() -> registerChildren(), deregisterChildren().
…te#children (ViewCollection->Array). Implemented Template#getViews() generator.
…oring in View and Template classes.
…in the component to wrap it in a single #element.
oskarwrobel
reviewed
Oct 27, 2017
src/iframe/iframeview.js
Outdated
|
|
||
| return new Promise( ( resolve, reject ) => { | ||
| deferred = { resolve, reject }; | ||
| } ); |
There was a problem hiding this comment.
Why not just
render() {
return new Promise( resolve => {
this.on( 'loaded', resolve );
super.render();
} ) ;
}?
There was a problem hiding this comment.
If tests are passing, I think it is the right way to render an IframeView
There was a problem hiding this comment.
I meant: you're probably right 😋
There was a problem hiding this comment.
It works fine but I think we don't need to resolve this promise outside of the promise scope. deferred variable doesn't have too much sense here. But it's a detail :)
|
It's worth to mention about |
oskarwrobel
approved these changes
Oct 27, 2017
|
FYI: I've just pushed the fixes to the branches. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Other: Implemented
View#rendermethod which replaces the#elementrendering upon the first reference and incorporates the#initmethod functionality. Closes ckeditor/ckeditor5#5384. Closes ckeditor/ckeditor5#5403.From now on
View#setTemplateandView#extendTemplatemethods are recommended as a shorthand forview.template = new Template( { ... } )andTemplate.extend( view.template ).BREAKING CHANGE: The
init()method in various UI components has been renamed torender(). Please refer to the documentation to learn more.BREAKING CHANGE: The
View#elementis no longer a getter which renders an element when first referenced. Use theView#render()method instead.BREAKING CHANGE:
Template#childrenproperty became anArray(previouslyViewCollection).BREAKING CHANGE:
View#addChildrenandView#removeChildrenmethods became#registerChildrenand#deregisterChildren.BREAKING CHANGE: The DOM structure of the
StickyPanelViewhas changed along with the class names. Please refer to the component documentation to learn more.Additional information
This PR comes with a branch constellation centralized in https://github.com/ckeditor/ckeditor5/tree/t/ckeditor5-ui/262:
Merge commit message for related branches:
Misc
ContextualBalloonfor a while.