Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

I/6232: Table properties: default value == no value #245

Merged
merged 12 commits into from
Feb 13, 2020
Merged

I/6232: Table properties: default value == no value #245

merged 12 commits into from
Feb 13, 2020

Conversation

jodator
Copy link
Contributor

@jodator jodator commented Feb 12, 2020

Suggested merge commit message (convention)

Internal: Make default value empty in the model. Closes ckeditor/ckeditor5#6232.


Additional information

  • Done - should work. Code style might need improvements and there's a lot of code duplication but this might be a topic for later.

@coveralls
Copy link

coveralls commented Feb 12, 2020

Coverage Status

Coverage remained the same at 100.0% when pulling c3a5fa8 on i/6232 into 97da473 on master.

@jodator jodator marked this pull request as ready for review February 13, 2020 07:34
@jodator
Copy link
Contributor Author

jodator commented Feb 13, 2020

AFAICS it fails only due to old friend:

Chrome 80.0.3987 (Linux 0.0.0) Table cell paragraph post-fixer should wrap in paragraph $text nodes placed directly in tableCell (on table cell modification) FAILED

@Reinmar Reinmar self-assigned this Feb 13, 2020
@Reinmar
Copy link
Member

Reinmar commented Feb 13, 2020

All look good to me. Waitin for confirmation from @ckeditor/qa-team.

@Mgsy
Copy link
Member

Mgsy commented Feb 13, 2020

We've checked it and looks good 👍

@Reinmar Reinmar merged commit b0c0591 into master Feb 13, 2020
@Reinmar Reinmar deleted the i/6232 branch February 13, 2020 10:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table properties: default value == no value
4 participants