This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 19
I/6197: Proper convertion of the table alignment property. #234
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
912eb71
TableProperties alignment conversion must consume attributes.
jodator d004c26
TableProperties alignment conversion must have higher priority conver…
jodator 2163596
Fix table properties downcast interoperability.
jodator 2b3511c
Add tests for overriding table cell properties.
jodator 9c7626a
Change output styles for alignment attribute.
jodator a99d186
Use downcast attributeToAttribute conversion helper for alignment att…
jodator b3dbe38
Use conversion.attributeToAttribute() helper for alignment property.
jodator 4839ebd
Merge branch 'i/6179' into i/6197
jodator 6aea6e5
Fix floats in table alignment conversion.
jodator 3634667
Remove .only from tests.
jodator 5af78ec
Change test for table alignment - center should not be converted.
jodator 32491a4
Fix table alignment command tests.
jodator 5d25bdd
Table alignment property should not convert "center" value.
jodator 681cb7b
Merge branch 'master' into i/6197
oleq a54e15a
Make default alignment without value in the UI.
jodator 734faa5
Merge branch 'master' into i/6197
jodator 30375a1
Remove to margin left/right from table alignment converters.
jodator ea06fc7
Fix table properties integration tests.
jodator File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it still necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes: ckeditor/ckeditor5#6199