Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Commit

Permalink
Merge pull request #262 from ckeditor/i/6343
Browse files Browse the repository at this point in the history
Internal: Made table selection and table clipboard core table features. Closes ckeditor/ckeditor5#6343.
  • Loading branch information
Reinmar authored Mar 6, 2020
2 parents e6eb3cd + 9296821 commit 3abc494
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 5 deletions.
12 changes: 9 additions & 3 deletions src/table.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ import Plugin from '@ckeditor/ckeditor5-core/src/plugin';

import TableEditing from './tableediting';
import TableUI from './tableui';
import TableSelection from './tableselection';
import TableClipboard from './tableclipboard';
import Widget from '@ckeditor/ckeditor5-widget/src/widget';

import '../theme/table.css';
Expand All @@ -20,8 +22,12 @@ import '../theme/table.css';
*
* For a detailed overview, check the {@glink features/table Table feature documentation}.
*
* This is a "glue" plugin that loads the {@link module:table/tableediting~TableEditing table editing feature}
* and {@link module:table/tableui~TableUI table UI feature}.
* This is a "glue" plugin that loads the following table features:
*
* * {@link module:table/tableediting~TableEditing editing feature},
* * {@link module:table/tableselection~TableSelection selection feature},
* * {@link module:table/tableclipboar~TableClipboard clipboard feature},
* * {@link module:table/tableui~TableUI UI feature}.
*
* @extends module:core/plugin~Plugin
*/
Expand All @@ -30,7 +36,7 @@ export default class Table extends Plugin {
* @inheritDoc
*/
static get requires() {
return [ TableEditing, TableUI, Widget ];
return [ TableEditing, TableUI, TableSelection, TableClipboard, Widget ];
}

/**
Expand Down
6 changes: 4 additions & 2 deletions tests/table.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,13 @@
import Table from '../src/table';
import TableEditing from '../src/tableediting';
import TableUI from '../src/tableui';
import TableSelection from '../src/tableselection';
import TableClipboard from '../src/tableclipboard';
import Widget from '@ckeditor/ckeditor5-widget/src/widget';

describe( 'Table', () => {
it( 'requires TableEditing, TableUI and Widget', () => {
expect( Table.requires ).to.deep.equal( [ TableEditing, TableUI, Widget ] );
it( 'requires TableEditing, TableUI, TableSelection, TableClipboard, and Widget', () => {
expect( Table.requires ).to.deep.equal( [ TableEditing, TableUI, TableSelection, TableClipboard, Widget ] );
} );

it( 'has proper name', () => {
Expand Down

0 comments on commit 3abc494

Please sign in to comment.