CKEditor: handle being torn down before initialization #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's easy, particularly in tests, to end up rendering the editor only to then quickly change a prop that causes it to no longer render. It's possible for this to happen quickly enough that `_initializeEditor()` hasn't finished running yet, thus ending up in `_createEditor()` with a null `element`. That ends up causing CKEditor itself to throw an exception, and ends up not defining the editor, which then makes the watchdog throw an exception. The latter error is not catchable in an error boundary due to its asynchronous nature. Fix this by making `_createEditor()` a little more defensive: make sure we have an element before bothering to create an editor. If we don't have one, we know we're in the midst of a teardown, so create a dummy editor so the watchdog has something to destroy. Signed-off-by: Kyle Fazzari <[email protected]>
Witoso
added
squad:core
|
@pomek will your team take a look? |
|
FYI, I did sign the CLA, not sure why your system thinks I haven't.
Just in case you're waiting for that to review this, @pomek. |
|
@vokiel could you check if it's signed? |
|
Check, all good ✔️ |
|
Any chance someone could take a look at this? @pomek, friendly ping. |
leadegroot
added a commit
to uqlibrary/fez-frontend
that referenced
this pull request
Nov 27, 2023
…appearing [PT #186068199] ckeditor probably doesnt currently work adequately ckeditor/ckeditor5-react#370 (comment) ckeditor/ckeditor5-react#383
|
Closing due to #383 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's easy, particularly in tests, to end up rendering the editor only to then quickly change a prop that causes it to no longer render. It's possible for this to happen quickly enough that
_initializeEditor()hasn't finished running yet, thus ending up in_createEditor()with a nullelement. That ends up causing CKEditor itself to throw an exception, and ends up not defining the editor, which then makes the watchdog throw an exception. The latter error is not catchable in an error boundary due to its asynchronous nature.Fix this by making
_createEditor()a little more defensive: make sure we have an element before bothering to create an editor. If we don't have one, we know we're in the midst of a teardown, so create a dummy editor so the watchdog has something to destroy.This might be related to #351, but I'm not certain.