Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow disabling watchdog in the component #373

Closed
Mgsy opened this issue Apr 28, 2023 · 3 comments · Fixed by #392
Closed

Allow disabling watchdog in the component #373

Mgsy opened this issue Apr 28, 2023 · 3 comments · Fixed by #392
Assignees
@martnpaneq
Labels
squad:platform Issue to be handled by the Platform team. support:2 An issue reported by a commercially licensed client. type:feature
Milestone
iteration 65

Comments

@Mgsy
Copy link
Member

Mgsy commented Apr 28, 2023

Description

This feature request is about introducing a possibility for removing Watchdog integration from the component.
@Mgsy Mgsy added type:feature squad:platform Issue to be handled by the Platform team. support:2 An issue reported by a commercially licensed client. labels Apr 28, 2023
@pomek
Copy link
Member

pomek commented Jun 7, 2023

Scope

@CKEditorBot CKEditorBot added the status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. label Jun 7, 2023
@martnpaneq martnpaneq self-assigned this Jun 14, 2023
@CKEditorBot CKEditorBot added status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. and removed status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. labels Jun 14, 2023
@martnpaneq martnpaneq mentioned this issue Jun 19, 2023
Merged
pomek added a commit that referenced this issue Jun 26, 2023
@pomek
Merge pull request #392 from ckeditor/i/373
3fa02f4 
Feature: Added `disableWatchdog` property to the React component. Closes #373.
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Jun 26, 2023
@CKEditorBot CKEditorBot added this to the iteration 65 milestone Jun 26, 2023
@martnpaneq martnpaneq mentioned this issue Jun 26, 2023
Merged
pomek added a commit to ckeditor/ckeditor5 that referenced this issue Jun 27, 2023
@pomek
Merge pull request #14467 from ckeditor/i/373
64f9d9e 
Docs: Added `disableWatchdog` property description in the React integration docs. See ckeditor/ckeditor5-react#373.
@glynam1
Copy link

glynam1 commented Aug 15, 2023

@pomek / @Mgsy

Is this expected to work within a CKEditor Context?
It appears that disabling watchdog within an editor that is contained within a CKEditor Context throws a soft plugin required error because the CloudServices plugin is not available .

It almost appears that the CloudServices plugin is implicitly provided through the watchdog coming from the context

@jake-netflix jake-netflix mentioned this issue Aug 28, 2023
Open
@jake-netflix
Copy link

It appears that disabling watchdog within an editor that is contained within a CKEditor Context throws a soft plugin required error because the CloudServices plugin is not available .

I ran into the same CloudServices soft required. Can't use disableWatchdog yet because my editors are in a context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@martnpaneq martnpaneq

Labels
squad:platform Issue to be handled by the Platform team. support:2 An issue reported by a commercially licensed client. type:feature
Projects
None yet
Milestone
iteration 65
Development

Successfully merging a pull request may close this issue.

Added disableWatchdog property to the React component. ckeditor/ckeditor5-react
6 participants
@pomek @Mgsy @CKEditorBot @jake-netflix @glynam1 @martnpaneq