-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate double-rendering in React StrictMode #294
Comments
React 18 is live (https://github.com/facebook/react/releases/tag/v18.0.0). |
This is a big issue. How can we fix it? |
same issue heree |
Same issue with console error: It appears when route switch and disappears after F5 or when direct link using. |
Fix: Fixed component double rendering in StrictMode. Closes #294.
We fixed the issue, and it should not occur in the latest version of the |
Was this console message fixed when you upgraded to 5.0.1? |
@pomek After I updated to ckeditor5-react 5.0.0 -> 5.0.1 I stopped getting the Maybe they were related? No traceback unfortunately:
|
That's good news that the error does not occur anymore. Perhaps it was related to promises. Before 5.0.1, they were ignored. Now the component waits to resolve them. |
That's what I suspect. It seems so. If it comes up again I (or anyone else who bumps into it) can make a new issue (and perhaps cite this if they find it in search) |
Hi. Got the same problem with ckeditor5-react 5.1.0 and React 18.2.0 - |
React
StrictMode
is a tool provided by React to highlight potential problems in React components. Whenckeditor5-react
is used within StrictMode, it double-renders the editor like thisinstead of normal appearance like this:
The reason is most likely that certain render-phase lifecycle methods in
ckeditor5-react
has unexpected side effects.If left unaddressed, these problems can lead to subtle bugs in when
ckeditor5-react
is used in full concurrent mode in React versions starting from 18 (currently in RC) because React 18 enable concurrent rendering.The text was updated successfully, but these errors were encountered: