Skip to content

Commit

Permalink
Merge pull request #511 from ckeditor/ck/alpha-manual-fixes
Browse files Browse the repository at this point in the history
Fix (manual): Indent button is no longer disabled in manual demos.
Fix (manual): Manual demos should point to existing documentation links.
Fix (manual): Image upload should be now possible in demos.
  • Loading branch information
Mati365 authored Aug 9, 2024
2 parents e874dea + 2cec287 commit 54e362c
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 10 deletions.
6 changes: 3 additions & 3 deletions demos/multiroot-react/App.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@ type Demo = 'editor' | 'rich' | 'context';

const multiRootEditorContent = {
intro: '<h2>Sample</h2><p>This is an instance of the ' +
'<a href="https://ckeditor.com/docs/ckeditor5/latest/builds/guides/overview.html#classic-editor">multi-root editor build</a>.</p>',
'<a href="https://ckeditor.com/docs/ckeditor5/latest/examples/builds/classic-editor.html">multi-root editor type</a>.</p>',
content: '<p>It is the custom content</p><figure class="image"><img src="/demos/sample.jpg" alt="CKEditor 5 Sample image."></figure>',
outro: '<p>You can use this sample to validate whether your ' +
'<a href="https://ckeditor.com/docs/ckeditor5/latest/builds/guides/development/custom-builds.html">custom build</a> works fine.</p>'
outro: '<p>You can use <a href="https://ckeditor.com/ckeditor-5/builder/">CKEditor Builder</a>' +
' to create a custom configuration with your favorite features.</p>'
};

const rootsAttributes = {
Expand Down
6 changes: 4 additions & 2 deletions demos/multiroot-react/MultiRootEditor.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@ import {
PictureEditing,
Table,
TableToolbar,
TextTransformation
TextTransformation,
Base64UploadAdapter
} from 'ckeditor5';

import 'ckeditor5/ckeditor5.css';
Expand Down Expand Up @@ -62,7 +63,8 @@ export default class MultiRootEditor extends MultiRootEditorBase {
PictureEditing,
Table,
TableToolbar,
TextTransformation
TextTransformation,
Base64UploadAdapter
];

public static override defaultConfig = {
Expand Down
9 changes: 6 additions & 3 deletions demos/react/App.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,17 @@ type Demo = 'editor' | 'context';

const editorContent = `
<h2>Sample</h2>
<p>This is an instance of the <a href="https://ckeditor.com/docs/ckeditor5/latest/builds/guides/overview.html#classic-editor">
<p>This is an instance of the <a href="https://ckeditor.com/docs/ckeditor5/latest/examples/builds/classic-editor.html">
classic editor build</a>.
</p>
<figure class="image">
<img src="/demos/sample.jpg" alt="CKEditor 5 Sample image." />
</figure>
<p>You can use this sample to validate whether your
<a href="https://ckeditor.com/docs/ckeditor5/latest/builds/guides/development/custom-builds.html">custom build</a> works fine.</p>
<p>
You can use
<a href="https://ckeditor.com/ckeditor-5/builder/">CKEditor Builder</a>
to create a custom build with your favorite features.
</p>
`;

export default function App(): JSX.Element {
Expand Down
8 changes: 6 additions & 2 deletions demos/react/ClassicEditor.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import {
ImageToolbar,
ImageUpload,
Indent,
IndentBlock,
Link,
List,
MediaEmbed,
Expand All @@ -30,7 +31,8 @@ import {
PictureEditing,
Table,
TableToolbar,
TextTransformation
TextTransformation,
Base64UploadAdapter
} from 'ckeditor5';

import 'ckeditor5/ckeditor5.css';
Expand All @@ -54,6 +56,7 @@ export default class ClassicEditor extends ClassicEditorBase {
ImageToolbar,
ImageUpload,
Indent,
IndentBlock,
Link,
List,
MediaEmbed,
Expand All @@ -62,7 +65,8 @@ export default class ClassicEditor extends ClassicEditorBase {
PictureEditing,
Table,
TableToolbar,
TextTransformation
TextTransformation,
Base64UploadAdapter
];

public static override defaultConfig = {
Expand Down

0 comments on commit 54e362c

Please sign in to comment.