Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable 'no-unused-vars' rule. #36

Merged
merged 2 commits into from
Sep 3, 2024
Merged

Enable 'no-unused-vars' rule. #36

merged 2 commits into from
Sep 3, 2024

Conversation

arkflpc
Copy link
Contributor

@arkflpc arkflpc commented Aug 29, 2024

Suggested merge commit message (convention)

Feature (eslint-plugin-ckeditor5-rules): Enable 'no-unused-vars' rule. See ckeditor/ckeditor5#17010.


Additional information

For example – encountered issues, assumptions you had to make, other affected tickets, etc.

@arkflpc arkflpc requested a review from pomek August 29, 2024 13:13
Reverted version bump.

Co-authored-by: Kamil Piechaczek <[email protected]>
@arkflpc arkflpc requested a review from pomek August 30, 2024 07:09
Copy link
Member

@pomek pomek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@arkflpc arkflpc merged commit 0145f1b into master Sep 3, 2024
1 check passed
@arkflpc arkflpc deleted the ck/17010-no-unused-vars branch September 3, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants