Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add rule requiring file extensions in exports #29

Merged

Conversation

filipsobol
Copy link
Member

@filipsobol filipsobol commented Dec 15, 2023

Suggested merge commit message (convention)

Other (eslint-plugin-ckeditor5-rules): Improved the ckeditor5-rules/require-file-extensions-in-imports to require a file extension in both imports and exports. See ckeditor/ckeditor5#13673.


Additional information

For example – encountered issues, assumptions you had to make, other affected tickets, etc.

@filipsobol filipsobol linked an issue Dec 15, 2023 that may be closed by this pull request
Copy link
Contributor

@psmyrek psmyrek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@psmyrek psmyrek merged commit 950a842 into master Dec 15, 2023
1 check passed
@psmyrek psmyrek deleted the ck/13673-add-rule-requiring-file-extensions-in-exports branch December 15, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make CKEditor 5 packages valid ESM
2 participants