This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
i/6053b: Link selection attributes should be cleared after inserting a link via Model#insertContent() for better UX
#261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a insertContent() for better UX.
…f promises for better readability.
|
I see that listening on insert content works nice. AFAICS the logic is pretty the same and straightforward - no fixing after selection change. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix: Link selection attributes should be cleared after inserting a link via
Model#insertContent()for better UX. Closes ckeditor/ckeditor5#6053.Additional information
A new approach to the problem (the old one) after a F2F talk with @Reinmar. Let's take a look at it and discuss it here.
FYI: I smuggled some async/await refactoring to the LinkEditing tests just like @jodator suggested in the old PR.