This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
T/ckeditor5/645: Implemented a 2-step editing, refreshed link UI #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…link. Refactored the LinkFormView.
…s UI first, if there's a link under the selection.
dkonopka
reviewed
Feb 1, 2018
| */ | ||
|
|
||
| .ck-link-actions { | ||
| & .ck-link-actions__preview { |
There was a problem hiding this comment.
Maybe we should remove empty class .ck-link-actions and start with .ck-link-actions__preview? We need specificity 020 here?
As I've checked display: inline-block for preview & overflow: hidden for the label is not overridden in 010 situation.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Feature: Implemented a 2–step link UI with a refreshed look&feel (see ckeditor/ckeditor5#645). Closes ckeditor/ckeditor5#4735.
BREAKING CHANGE: The structure of the link UI has changed dramatically. Some pieces of the
LinkFormViewbelong now to theLinkActionsViewclass. The CSS classes have also changed along with component templates.Additional information