Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

t/52: Removed the "Unlink" button from the toolbars #148

Merged
merged 4 commits into from
Aug 22, 2017
Merged

t/52: Removed the "Unlink" button from the toolbars #148

merged 4 commits into from
Aug 22, 2017

Conversation

@Reinmar
Copy link
Member

Reinmar commented Aug 21, 2017

We were supposed to also remove the UI component for it.

@oleq
Copy link
Member Author

oleq commented Aug 22, 2017

Why exactly? People may want to use it after all.

@Reinmar
Copy link
Member

Reinmar commented Aug 22, 2017

Because, as disscussed, if we keep it in the code we need to maintain it. And if we don't use it, then it doesn't make much sense.

Plus, to keep the code size as low as possible, this should be a separate feature. That will avoid loading its icon.

@oleq
Copy link
Member Author

oleq commented Aug 22, 2017

OK, I removed the UI component. I also found out that I missed changes in the build-classic package so I updated it too.

The CI branch is https://github.com/ckeditor/ckeditor5/tree/t/ckeditor5-link/52.

@Reinmar
Copy link
Member

Reinmar commented Aug 22, 2017

You somehow missed all the docs:

image

@Reinmar
Copy link
Member

Reinmar commented Aug 22, 2017

I'll handle them while closing this PR.

@oleq
Copy link
Member Author

oleq commented Aug 22, 2017

The mystery why I missed them is folder_exclude_patterns in the ST project configuration :P

@Reinmar
Copy link
Member

Reinmar commented Aug 22, 2017

I thought so :D

@Reinmar Reinmar merged commit 3b7fda7 into master Aug 22, 2017
@Reinmar Reinmar deleted the t/52 branch August 22, 2017 14:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the "unlink" button from the toolbar
2 participants