Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem with Esc handling #4773

Closed
oskarwrobel opened this issue Mar 28, 2017 · 2 comments · Fixed by ckeditor/ckeditor5-link#112
Closed

Problem with Esc handling #4773

oskarwrobel opened this issue Mar 28, 2017 · 2 comments · Fixed by ckeditor/ckeditor5-link#112
Assignees
@oleq
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:link type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 10

Comments

@oskarwrobel
Copy link
Contributor

When the balloon element is focused but none of the form fields is focused as well then it is impossible to close balloon by Esc.

mar-28-2017 19-51-09
@fredck
Copy link
Contributor

fredck commented Apr 7, 2017

The balloon should not be focused by click.

oleq referenced this issue in ckeditor/ckeditor5-link Apr 21, 2017
@oleq
Fix: Esc should close the link panel even if none of the fields is fo…
20e451f 
…cused. Closes #90.
@oleq oleq self-assigned this Apr 21, 2017
oskarwrobel referenced this issue in ckeditor/ckeditor5-link Apr 24, 2017
@oskarwrobel
Fix: Esc key should close the link panel even if none of the `LinkFor…
866fa49 
…mView` fields is focused. Closes #90.

t/90: Esc key should close the link panel even if none of the form fields is focused
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-link Oct 9, 2019
@mlewand mlewand added this to the iteration 10 milestone Oct 9, 2019
@mlewand mlewand added domain:ui/ux This issue reports a problem related to UI or UX. status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:link labels Oct 9, 2019
@oleq oleq mentioned this issue Oct 11, 2019
Merged
@jodator
Copy link
Contributor

jodator commented Oct 21, 2020

Happened again: #8079.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:link type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 10
5 participants
@jodator @fredck @oskarwrobel @oleq @mlewand