Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Added validation for Position's getters #1777

Merged
merged 3 commits into from
Aug 12, 2019
Merged

Added validation for Position's getters #1777

merged 3 commits into from
Aug 12, 2019

Conversation

Reinmar
Copy link
Member

@Reinmar Reinmar commented Aug 7, 2019 •
edited by pomek
Loading

Suggested merge commit message (convention)

Other: Position getters (such as #parent or #index) will throw when position points at an incorrect place in its root. Closes ckeditor/ckeditor5#4531.

@Reinmar Reinmar requested a review from mlewand August 7, 2019 14:53
@coveralls
Copy link

coveralls commented Aug 7, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 830651b on t/1776 into 44068ac on master.

@Reinmar
Copy link
Member Author

Reinmar commented Aug 8, 2019

Gotta fix CC.

@Reinmar Reinmar requested review from jodator and removed request for mlewand August 12, 2019 09:54
@Reinmar Reinmar assigned jodator and unassigned mlewand Aug 12, 2019
jodator
jodator approved these changes Aug 12, 2019
View reviewed changes
Copy link
Contributor

@jodator jodator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@jodator jodator merged commit a359866 into master Aug 12, 2019
@jodator jodator deleted the t/1776 branch August 12, 2019 12:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jodator jodator jodator approved these changes

Assignees

@jodator jodator

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validate position.parent's output
4 participants
@Reinmar @coveralls @jodator @mlewand