This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Docs: Added example to clarify the case explained in the ticket. #1774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scofalik
reviewed
Aug 6, 2019
src/conversion/upcastdispatcher.js
Outdated
| * // Convert <p>'s font-size style. | ||
| * // Note: You should use a low-priority observer in order to ensure that | ||
| * // it's executed after the element-to-element converter. | ||
| * editor.data.upcastDispatcher.on( 'element', ( evt, data, conversionApi ) => { |
There was a problem hiding this comment.
element or element:p? The comment says <p>.
There was a problem hiding this comment.
Yup, my bad. I've been testing too many things.
Reinmar
commented
Aug 6, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Docs: Added an example to clarify how to implement custom attribute upcast converters. Closes ckeditor/ckeditor5#4529.
Additional information
I also fixed the documentation for default priorities.