Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Internal: Allowed $marker element in any parent element. #1698

Merged
merged 3 commits into from
Mar 15, 2019
Merged

Internal: Allowed $marker element in any parent element. #1698

merged 3 commits into from
Mar 15, 2019

Conversation

oskarwrobel
Copy link
Contributor

@oskarwrobel oskarwrobel commented Mar 15, 2019 •
edited by pomek
Loading

Suggested merge commit message (convention)

Internal: Allowed $marker element in any parent element. Closes ckeditor/ckeditor5#4495.

Additional information

For example – encountered issues, assumptions you had to make, other affected tickets, etc.

@coveralls
Copy link

coveralls commented Mar 15, 2019 •
edited
Loading

Coverage Status

Coverage increased (+9.0e-06%) to 99.977% when pulling 314c531 on t/1697 into cf56d90 on master.

scofalik
scofalik reviewed Mar 15, 2019
View reviewed changes
src/model/model.js Outdated Show resolved Hide resolved
scofalik
scofalik reviewed Mar 15, 2019
View reviewed changes
src/model/model.js Outdated Show resolved Hide resolved
@scofalik scofalik merged commit 3706324 into master Mar 15, 2019
@scofalik scofalik deleted the t/1697 branch March 15, 2019 15:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@scofalik scofalik scofalik left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

$marker element should be allowed everywhere
3 participants
@oskarwrobel @coveralls @scofalik