This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Feature: Introduced Writer#refreshMarker method.
#1694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We agreed to use |
…ugh `Writer#updateMarker()` method.
scofalik
approved these changes
Mar 12, 2019
src/model/markercollection.js
Outdated
| const marker = this._markers.get( markerName ); | ||
|
|
||
| if ( !marker ) { | ||
| throw new CKEditorError( 'markers-refresh-marker-not-exists: Marker with provided name does not exists.' ); |
There was a problem hiding this comment.
Suggested change
| throw new CKEditorError( 'markers-refresh-marker-not-exists: Marker with provided name does not exists.' ); | |
| throw new CKEditorError( 'markercollection-refresh-marker-not-exists: Marker with provided name does not exists.' ); |
| throw new CKEditorError( 'markers-refresh-marker-not-exists: Marker with provided name does not exists.' ); | ||
| } | ||
|
|
||
| const range = marker.getRange(); |
There was a problem hiding this comment.
Suggested change
| const range = marker.getRange(); | |
| const range = marker.getRange(); | |
src/model/writer.js
Outdated
| @@ -939,13 +939,38 @@ export default class Writer { | |||
| } | |||
|
|
|||
| /** | |||
| * Adds or updates a {@link module:engine/model/markercollection~Marker marker}. Marker is a named range, which tracks | |||
| * Adds updates or refreshes a {@link module:engine/model/markercollection~Marker marker}. Marker is a named range, which tracks | |||
There was a problem hiding this comment.
Suggested change
| * Adds updates or refreshes a {@link module:engine/model/markercollection~Marker marker}. Marker is a named range, which tracks | |
| * Adds, updates or refreshes a {@link module:engine/model/markercollection~Marker marker}. Marker is a named range, which tracks |
src/model/writer.js
Outdated
| * changes in the document and updates its range automatically, when model tree changes. Still, it is possible to change the | ||
| * marker's range directly using this method. | ||
| * | ||
| * As the first parameter you can set marker name or instance. If none of them is provided, new marker, with a unique | ||
| * name is created and returned. | ||
| * | ||
| * As the second parameter you can set the new marker data or leave this parameter as empty what will only refresh |
There was a problem hiding this comment.
Suggested change
| * As the second parameter you can set the new marker data or leave this parameter as empty what will only refresh | |
| * As the second parameter you can set the new marker data or leave this parameter as empty which will just refresh |
tests/model/markercollection.js
Outdated
| it( 'should throw if marker does not exist', () => { | ||
| expect( () => { | ||
| markers._refresh( 'name' ); | ||
| } ).to.throw( CKEditorError, 'markers-refresh-marker-not-exists: Marker with provided name does not exists.' ); |
There was a problem hiding this comment.
Suggested change
| } ).to.throw( CKEditorError, 'markers-refresh-marker-not-exists: Marker with provided name does not exists.' ); | |
| } ).to.throw( CKEditorError, 'markercollection-refresh-marker-not-exists: Marker with provided name does not exists.' ); |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Feature: Added possibility to refresh the marker with no changes through
Writer#updateMarker()method. Closes ckeditor/ckeditor5#4471.Additional information
For example – encountered issues, assumptions you had to make, other affected tickets, etc.