Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

t/1301: The bindTwoStepCaretToAttribute should not fail in more complex cases #1406

Merged
merged 24 commits into from
Apr 18, 2018
Merged

t/1301: The bindTwoStepCaretToAttribute should not fail in more complex cases #1406

merged 24 commits into from
Apr 18, 2018

Commits on Apr 16, 2018

  1. Tests: Refactoring in bindTwoStepCaretToAttribute tests.

    @oleq
    oleq committed Apr 16, 2018
    Configuration menu
    Copy the full SHA
    6d7a74d View commit details
    Browse the repository at this point in the history

  2. Fix: The two step caret movement should not engage when approaching u… 

    …nrelated attributes inside the main attribute.
    @oleq
    oleq committed Apr 16, 2018
    Configuration menu
    Copy the full SHA
    c301696 View commit details
    Browse the repository at this point in the history

  3. Code refactoring.

    @oleq
    oleq committed Apr 16, 2018
    Configuration menu
    Copy the full SHA
    e460049 View commit details
    Browse the repository at this point in the history

  4. Tests/Docs: Updated Writer and DocumentSelection docs and tests to th… 

    …e newest API.
    @oleq
    oleq committed Apr 16, 2018
    Configuration menu
    Copy the full SHA
    c12b045 View commit details
    Browse the repository at this point in the history

  5. Tests: Added a test to verify 2-SCM acts properly when facing externa… 

    …l changes.
    @oleq
    oleq committed Apr 16, 2018
    Configuration menu
    Copy the full SHA
    ebb407f View commit details
    Browse the repository at this point in the history

  6. Tests: Added tests to verify 2-SCM with multiple attributes.

    @oleq
    oleq committed Apr 16, 2018
    Configuration menu
    Copy the full SHA
    86e3e34 View commit details
    Browse the repository at this point in the history

  7. Docs: Extended documentation in the engine/utils/bindtwostepcarettoat… 

    …tribute module.
    @oleq
    oleq committed Apr 16, 2018
    Configuration menu
    Copy the full SHA
    16a7220 View commit details
    Browse the repository at this point in the history

  8. Tests: Added an additional test case.

    @oleq
    oleq committed Apr 16, 2018
    Configuration menu
    Copy the full SHA
    447750f View commit details
    Browse the repository at this point in the history

  9. Tests: Added an additional tests case.

    @oleq
    oleq committed Apr 16, 2018
    Configuration menu
    Copy the full SHA
    88caaad View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2018

  1. Fix: The filler logic in the renderer should not interfere the 2-step… 

    … caret movement.
    @oleq
    oleq committed Apr 17, 2018
    Configuration menu
    Copy the full SHA
    e1c02a0 View commit details
    Browse the repository at this point in the history

  2. Docs and code refactoring.

    @oleq
    oleq committed Apr 17, 2018
    Configuration menu
    Copy the full SHA
    991a96f View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2018

  1. Code refactoring.

    @oleq
    oleq committed Apr 18, 2018
    Configuration menu
    Copy the full SHA
    763f32a View commit details
    Browse the repository at this point in the history

  2. Code refactoring.

    @oleq
    oleq committed Apr 18, 2018
    Configuration menu
    Copy the full SHA
    bff08fb View commit details
    Browse the repository at this point in the history

  3. Docs: Fixed outdated docs in the bindTwoStepCaretToAttribute helper.

    @oleq
    oleq committed Apr 18, 2018
    Configuration menu
    Copy the full SHA
    5be31ef View commit details
    Browse the repository at this point in the history

  4. Code refactoring in the bindTwoStepCaretToAttribute helper.

    @oleq
    oleq committed Apr 18, 2018
    Configuration menu
    Copy the full SHA
    411f952 View commit details
    Browse the repository at this point in the history

  5. Code refactoring in the bindTwoStepCaretToAttribute helper.

    @oleq
    oleq committed Apr 18, 2018
    Configuration menu
    Copy the full SHA
    0c1d47b View commit details
    Browse the repository at this point in the history

  6. Fix: The bindTwoStepCaretToAttribute helper should listen to keydown … 

    …with the highest priority.
    @oleq
    oleq committed Apr 18, 2018
    Configuration menu
    Copy the full SHA
    dc66333 View commit details
    Browse the repository at this point in the history

  7. Fix: Any further view.document#keydown event listeners should not be … 

    …called if the two-step called movement engages.
    @oleq
    oleq committed Apr 18, 2018
    Configuration menu
    Copy the full SHA
    4f6d9d9 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'master' into t/1301

    @oleq
    oleq committed Apr 18, 2018
    Configuration menu
    Copy the full SHA
    649f76d View commit details
    Browse the repository at this point in the history

  9. Code refactoring: Fixed confusing variable names in helpers.

    @oleq
    oleq committed Apr 18, 2018
    Configuration menu
    Copy the full SHA
    24f8e2f View commit details
    Browse the repository at this point in the history

  10. Fix: Pressing arrow left/right at the start/end of the block which is… 

    … the boundary of an attribute should engage the two-step caret movement.
    @oleq
    oleq committed Apr 18, 2018
    Configuration menu
    Copy the full SHA
    e89e69d View commit details
    Browse the repository at this point in the history

  11. Fix: Jumping over the filler should not be hindered by the two-step c… 

    …aret movement.
    @oleq
    oleq committed Apr 18, 2018
    Configuration menu
    Copy the full SHA
    d32625f View commit details
    Browse the repository at this point in the history

  12. Docs: Fixed typos in TwoStepCaretHandler docs.

    @oleq
    oleq committed Apr 18, 2018
    Configuration menu
    Copy the full SHA
    8f964bd View commit details
    Browse the repository at this point in the history

  13. Fix: The two-step caret movement could handle the single-character-at… 

    …tribute-preceded-by-some-text-at-the-end-of-the-block-case.
    @oleq
    oleq committed Apr 18, 2018
    Configuration menu
    Copy the full SHA
    446edb9 View commit details
    Browse the repository at this point in the history