Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusted the changelog generator to match to planned changes related to merging issue trackers #552

Merged
merged 2 commits into from
Aug 26, 2019

Conversation

pomek
Copy link
Member

@pomek pomek commented Aug 23, 2019

Suggested merge commit message (convention)

Other: Adjusted the changelog generator to match to planned changes related to merging issue trackers. Closes ckeditor/ckeditor5#1988.

BREAKING CHANGE: Due to merging our issue trackers, pkgJson.bugs will point to the same place for every package. We cannot rely on this value anymore. See ckeditor/ckeditor5#1988. Instead of we can take a value from pkgJson.repository and adjust it to match to our requirements.


Additional information

This PR won't change anything in our project because we already have defined pkgJson.repository for each package but if somebody uses the tool and he hasn't defined the value, the tool will throw an ugly error and that's why I marked it as BC.

@coveralls
Copy link

coveralls commented Aug 23, 2019

Coverage Status

Coverage increased (+0.02%) to 88.978% when pulling c05e7a1 on t/ckeditor5/1988 into ebdec66 on master.

@Reinmar Reinmar self-assigned this Aug 23, 2019
@Reinmar Reinmar added this to the iteration 26 milestone Aug 23, 2019
@Reinmar Reinmar merged commit acfe1a6 into master Aug 26, 2019
@Reinmar Reinmar deleted the t/ckeditor5/1988 branch August 26, 2019 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update "bugs" in package.json to point to ckeditor5
3 participants