Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded dependencies #437

Merged
merged 5 commits into from
Sep 24, 2018
Merged

Upgraded dependencies #437

merged 5 commits into from
Sep 24, 2018

Conversation

pomek
Copy link
Member

@pomek pomek commented Sep 10, 2018

Suggested merge commit message (convention)

Internal: Upgraded dependencies. Closes #436.

@pomek pomek requested a review from Reinmar September 10, 2018 06:58
@coveralls
Copy link

coveralls commented Sep 10, 2018

Coverage Status

Coverage remained the same at 90.357% when pulling 6cd8e9f on t/436 into a1ddfba on master.

@@ -36,7 +36,7 @@
"mkdirp": "^0.5.1",
"mocha": "^5.0.5",
"mockery": "^2.1.0",
"postcss-loader": "^2.1.1",
"postcss-loader": "^3.0.0",
"raw-loader": "^0.5.1",
"sinon": "^6.1.2",
"style-loader": "^0.21.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Different than in ckeditor5

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please synchronise these dependencies with ckeditor5

Copy link
Member

@Reinmar Reinmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not in sync with ckeditor5.

@@ -9,6 +9,7 @@
"@ckeditor/jsdoc-plugins": "^2.0.0",
"jsdoc": "3.4.3",
"map-stream": "^0.0.7",
"tmp": "0.0.33",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Precisely version 0.0.33? Not ^0.0.33?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants