Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Critical bug when ckeditor removed from dom before loaded #110

Closed
bhugot opened this issue Jun 4, 2020 · 7 comments
Closed

Critical bug when ckeditor removed from dom before loaded #110

bhugot opened this issue Jun 4, 2020 · 7 comments
Assignees
Labels
status:confirmed An issue confirmed by the development team. type:bug A bug.

Comments

@bhugot
Copy link
Contributor

bhugot commented Jun 4, 2020

Are you reporting a feature request or a bug?

Hello, we found a bug maybe related to ckeditor itself. if the component is removed from dom before initialisation you get Cannot read property 'unselectable' of null.

here is a sample https://stackblitz.com/edit/angular-ivy-rgaeks?file=src%2Fapp%2Fdemo%2Fdemo.component.ts

If you either have a way to fix this or could fix it.
Regards

bhugot added a commit to bhugot/ckeditor4-angular that referenced this issue Jun 4, 2020
@bhugot
Copy link
Contributor Author

bhugot commented Jun 6, 2020

The fix is here #111

@f1ames f1ames added status:confirmed An issue confirmed by the development team. type:bug A bug. workload:low labels Jun 9, 2020
@f1ames f1ames self-assigned this Jun 9, 2020
f1ames pushed a commit to bhugot/ckeditor4-angular that referenced this issue Jun 25, 2020
@f1ames
Copy link
Contributor

f1ames commented Jun 25, 2020

Fixed in d3ceee6.

@f1ames f1ames closed this as completed Jun 25, 2020
@bhugot
Copy link
Contributor Author

bhugot commented Jun 25, 2020

Any ETA on release? Thanks

@f1ames
Copy link
Contributor

f1ames commented Jun 26, 2020

We plan to release new version next week.

@f1ames
Copy link
Contributor

f1ames commented Jul 3, 2020

Hi @bhugot, the new package version (1.2.2) with the fix is out on NPM (https://www.npmjs.com/package/ckeditor4-angular) 🎉👏

@boris27
Copy link

boris27 commented Jul 3, 2020

hi guys, i have little different situation, and your fix in 1.2.2 doesnt work for me

this is example of above code, little modified to exampled my situation)
https://stackblitz.com/edit/angular-ivy-taveju?file=src%2Fapp%2Fapp.component.ts

can you help with this? @f1ames

@f1ames
Copy link
Contributor

f1ames commented Jul 3, 2020

Hi @boris27,

please report a separate issue in this repository describing your case so we can keep track of your issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:confirmed An issue confirmed by the development team. type:bug A bug.
Projects
None yet
Development

No branches or pull requests

3 participants