Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade nox-poetry to use poetry 1.2 / py38+ #929

Closed

Conversation

staticdev
Copy link
Contributor

@staticdev staticdev commented Oct 11, 2022

@cjolowicz I created this proposal solution to make nox-poetry work with poetry 1.2+.

The most important problem is that a project with flake8 cannot be installed together with poetry 1.2 on python 3.7. They have unsolvable importlib_metadata restrictions. Flake8 will not create a new version to fix that, so I instead raised the minimum version of python to 3.8. This enables dependency upgrades for the foreseeable future.

@cjolowicz cjolowicz mentioned this pull request Nov 8, 2022
@cjolowicz
Copy link
Owner

cjolowicz commented Nov 8, 2022

Thanks for working on this!

I've two issues with this:

  • I don't like breaking Poetry 1.1 yet (especially not for a warning).
  • I'm not comfortable dropping Python 3.7 before its EOL.

These dependencies are only used for development. Can we use environment markers to require Python 3.8? We'd lose testing for Python 3.7 though, I'm not sure how I feel about that.

As for Poetry 1.1, we'd need to find out which version we have, and use the invocation that's compatible with it.

@staticdev
Copy link
Contributor Author

@cjolowicz I think first issue is the easier one, we can continue using --dev and we continue with the warning on 1.2.

For python 3.7, I argued with flake8 developers and they will not change anymore to maintain compatibility with importlib_metadata. I am not aware of a way to restrict to python 3.8 just for dev dependencies, maybe is a good solution.

My 50 cents, there is still 7 months until EOL of Py3.7, honestly it don't think it is worth extra effort to keep support since we have Python 3.11 now and supporting 4 minor versions is already ahead of 95% of all open and closed-source projects I know. Also migration from Python 3.7 to 3.8 is very smooth compared to previous upgrades from Python I've seen before.

Of course, you are the lead here, so it is your call.

@staticdev
Copy link
Contributor Author

staticdev commented Nov 8, 2022

UPDATE: I rebased my PR. It works now with poetry 1.0.0+ again. At the cost of not closing #873 anymore.

@johnthagen
Copy link

FWIW, Python 3.7 goes end of life tomorrow, so perhaps nox-poetry can drop support then

@cjolowicz
Copy link
Owner

cjolowicz commented Jun 30, 2023

FWIW, Python 3.7 goes end of life tomorrow, so perhaps nox-poetry can drop support then

I've added an environment marker to restrict Flake8 and plugins to Python >= 3.8, so this should no longer be an issue. See #1118

@edgarrmondragon
Copy link
Contributor

Superseded by #1213 and #1225

@staticdev staticdev closed this Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants