feat: use pip sources config from poetry #887
Open
+94
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raddessi
commented
Sep 13, 2022
Comment on lines
+27
to
+30
|
|
||
| [[tool.poetry.source]] | ||
| name = "pypi-all-source2" | ||
| url = "https://pypi.python.org/all" |
There was a problem hiding this comment.
poetry export is not actually including this as an extra index, but that seems like an upstream issue.
Comment on lines
+262
to
+265
| requirements_text = self.poetry.export() | ||
| constraints = to_constraints(requirements_text) | ||
| pip_args = "\n".join(to_global_pip_args(requirements_text)) | ||
| path.write_text("\n".join([pip_args, constraints])) |
There was a problem hiding this comment.
I'm not sure if this data should be here or sent as arguments in the install command. Thoughts?
Comment on lines
+184
to
+185
| # args += to_global_pip_args(requirements) | ||
|
|
There was a problem hiding this comment.
This is where I had the config being injected before. I'll update this based on your opinion of how to best proceed.
|
This current setup produces a constraints file I'm not sure if this index will be read correctly when in the constrains file, I will have to test that. |
|
There's now #1040 too, which seems similar to this. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of #679 which was closed because I didn't create a feature branch :/ my apologies.
Closes #398
What do you think about this version? I'm not sure where the best place to put the args at is.. either in the
installcommand as args or in the constraints file.