assert: fix deepEqual/deepStrictEqual on equivalent typed arrays

The typed array's underlying ArrayBuffer is used in `Buffer.from`. Let's respect it's .byteOffset or .byteLength (i.e. position within the parent ArrayBuffer). Fixes: nodejs#8001 PR-URL: nodejs#8002 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Prince John Wesley <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
cjihrig · Nov 23, 2016 · 41546ff · 41546ff
1 parent 54c38eb
commit 41546ff
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/lib/assert.js b/lib/assert.js
@@ -176,8 +176,13 @@ function _deepEqual(actual, expected, strict, memos) {
              pToString(actual) === pToString(expected) &&
              !(actual instanceof Float32Array ||
                actual instanceof Float64Array)) {
-    return compare(new Buffer(actual.buffer),
-                   new Buffer(expected.buffer)) === 0;
+    return compare(
+      new Buffer(actual.buffer).slice(actual.byteOffset,
+                                      actual.byteOffset +
+                                      actual.byteLength),
+      new Buffer(expected.buffer).slice(expected.byteOffset,
+                                        expected.byteOffset +
+                                        expected.byteLength)) === 0;
 
   // 7.5 For all other Object pairs, including Array objects, equivalence is
   // determined by having the same number of owned properties (as verified