This repository was archived by the owner on Jul 24, 2024. It is now read-only.
[PARO-779] Prep for v2.2.1 release; remove six dependency #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am going to merge this pull request and start the release process for v2.2.1 tomorrow morning (Tuesday June 30). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
sixdependency entirely. Since python-glmnet is python 3 only,sixshouldn't be used anymore.I wasn't aware
sixwas still actually called until after the v2.2.0 release and while working through the conda-forge release (see conda-forge/glmnet-feedstock#14, which I had to abandon). At #64, all builds passed becausesixwas available viapytestin the build environment.