Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to skip provider registrations for the terraform azure provider. #408

Merged
merged 3 commits into from
Oct 28, 2024

Conversation

lagosr-google
Copy link
Contributor

Description

Only affects AZURE deployments.

Will configure the azurerm TF provider to skip_provider_registrations when the variable AZURE_SKIP_PROVIDER_REGISTRATION is set to "true".

The variable is defaulted to "false" and set as optional.

Tested by deploying onto azure.

Checklist

General

  • Added the correct label
  • Assigned to a specific person or civiform/deployment-system
  • Created tests which fail without the change (if possible)
  • Performed manual testing (at a minimum run bin/setup without your changes and then bin/deploy with your changes to ensure your changes don't break existing deployments)
  • Extended the README / documentation, if necessary

Instructions for manual testing

Ran the azure deployment script. -- Documentation for AZURE deployments is in progress.

@lagosr-google lagosr-google added bug Something isn't working enhancement New feature or request labels Oct 25, 2024
@lagosr-google lagosr-google requested review from dkatzz and a team October 25, 2024 23:10
@lagosr-google lagosr-google self-assigned this Oct 25, 2024
@lagosr-google lagosr-google marked this pull request as ready for review October 25, 2024 23:11
@lagosr-google lagosr-google requested review from a team and removed request for a team October 25, 2024 23:16
@lagosr-google lagosr-google merged commit 46fa72e into main Oct 28, 2024
7 checks passed
@lagosr-google lagosr-google deleted the lagosr/skip-provider-registration branch October 28, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants