-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide a knob to optionally skip creating the VPC related resources #330
Conversation
Thanks for fixing this, @yegle! Would you mind updating the title to remove the "revert" parts. And then in the description could you include a bit more information about what changed and also include the github issue it relates to (similar to what was included in the original PR, but with some information about what changed between that PR and this one to fix the issue)? And could you also include in the description how you tested it? |
PR description updated, PTAL. |
Could we try testing with |
With the Testing w/o external vpc configs:
Output:
( I did not test w/ external vpc configs. We will need to work with the CE on this, since if the CE partially sets up the VPC using the Terraform config and then sets the When the CE decides to use this knob, we should work closely with them, run SGTY? |
We'll actually be using a different AWS account for them for this deployment than their previous deployment, so we shouldn't have to do the |
Description
Provide a
var.external_vpc
to specify the VPC settings that are not managed by the Terraform configs.Checklist
General
civiform/deployment-system
bin/setup
without your changes and thenbin/deploy
with your changes to ensure your changes don't break existing deployments)Instructions for manual testing
Tested by patching this change to the checkout folder against my dev environment, w/o
vars.external_vpc
.(NOTE: it will be difficult to test w/
vars.external_vpc
, as Terraform will try to destroy some resources)Issue(s) this completes
Fixes civiform/civiform#7378
This reverts commit ed78f28. It also fixed the breakage originally introduced in f1e3565, where a local variable was referenced without the
local.
prefix.