Add remaining variables for RDS alarms and enable some by default #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bion
suggested changes
Jul 17, 2023
bion
approved these changes
Jul 18, 2023
dkatzz
added a commit
that referenced
this pull request
Jul 19, 2023
Add alarm for transaction ID wraparound and anomalous database connections, which can both be configured through setting a boolean to true. This completes bringing over the alarms from https://github.com/lorenzoaiello/terraform-aws-rds-alarms, which was started in #213 Related to [#5078](civiform/civiform#5078)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the warning that items have been updated outside of terraform, in addition to allowing for more configurability by having the setup of these alarms in our repo.
Many of these alarms were brought over from https://github.com/lorenzoaiello/terraform-aws-rds-alarms
I've turned on some by default based on the proposal
The only two that I still need to add are connection_count_anomalous and maximum_used_transaction_ids_too_high, but I need to add some extra variables for those, so I'll do that in a separate PR.
#5078, #5109