Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remaining variables for RDS alarms and enable some by default #213

Merged
merged 4 commits into from
Jul 18, 2023

Conversation

dkatzz
Copy link
Contributor

@dkatzz dkatzz commented Jul 17, 2023

This removes the warning that items have been updated outside of terraform, in addition to allowing for more configurability by having the setup of these alarms in our repo.

Many of these alarms were brought over from https://github.com/lorenzoaiello/terraform-aws-rds-alarms

I've turned on some by default based on the proposal

The only two that I still need to add are connection_count_anomalous and maximum_used_transaction_ids_too_high, but I need to add some extra variables for those, so I'll do that in a separate PR.

#5078, #5109

@dkatzz dkatzz self-assigned this Jul 17, 2023
@dkatzz dkatzz added the enhancement New feature or request label Jul 17, 2023
@dkatzz dkatzz requested review from a team and bion and removed request for a team July 17, 2023 19:35
cloud/aws/templates/aws_oidc/alarms.tf Outdated Show resolved Hide resolved
cloud/aws/templates/aws_oidc/alarms.tf Outdated Show resolved Hide resolved
cloud/aws/templates/aws_oidc/alarms.tf Outdated Show resolved Hide resolved
@dkatzz dkatzz requested a review from bion July 18, 2023 15:40
@dkatzz dkatzz merged commit 3c71d88 into main Jul 18, 2023
5 checks passed
@dkatzz dkatzz deleted the move-alarms branch July 18, 2023 16:38
dkatzz added a commit that referenced this pull request Jul 19, 2023
Add alarm for transaction ID wraparound and anomalous database
connections, which can both be configured through setting a boolean to
true.

This completes bringing over the alarms from
https://github.com/lorenzoaiello/terraform-aws-rds-alarms, which was
started in #213

Related to [#5078](civiform/civiform#5078)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants