Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unreplaced template vars in civicrm.settings.php when using wp-cli installer #257

Merged
merged 1 commit into from
Oct 12, 2021
Merged

Fix unreplaced template vars in civicrm.settings.php when using wp-cli installer #257

merged 1 commit into from
Oct 12, 2021

Conversation

demeritcowboy
Copy link
Contributor

See also civicrm/civicrm-joomla#63

e.g. it leaves behind the literal string %%dbSSL%% in the DSN.

@kcristiano
Copy link
Member

@davecivicrm Good pickup. This does correct the issue. I've done an r-run and this works as expected.

I have also discovered that the // %%extraSettings%% is not expanded on a wp-cli install so we should fix that in a separate PR.

@kcristiano kcristiano merged commit 11fb76b into civicrm:master Oct 12, 2021
@demeritcowboy
Copy link
Contributor Author

Thanks!

@demeritcowboy demeritcowboy deleted the dbssl branch October 12, 2021 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@demeritcowboy @kcristiano